Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: Source/core/dom/ContainerNode.cpp

Issue 1023393002: Cache element indices for :nth-child and :nth-last-child selectors. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Moved nth-index-cache scope to updateStyle Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/ContainerNode.cpp
diff --git a/Source/core/dom/ContainerNode.cpp b/Source/core/dom/ContainerNode.cpp
index 5ca16c88a4f7091f55fbf2ad4120deaef2db9de2..d67f545f619f92dfdf3e03a0d5e3f446ce8196f9 100644
--- a/Source/core/dom/ContainerNode.cpp
+++ b/Source/core/dom/ContainerNode.cpp
@@ -34,6 +34,7 @@
#include "core/dom/NodeLayoutStyle.h"
#include "core/dom/NodeRareData.h"
#include "core/dom/NodeTraversal.h"
+#include "core/dom/NthIndexCache.h"
#include "core/dom/SelectorQuery.h"
#include "core/dom/StaticNodeList.h"
#include "core/dom/StyleEngine.h"
@@ -855,6 +856,7 @@ void ContainerNode::childrenChanged(const ChildrenChange& change)
setChildNeedsStyleRecalc();
markAncestorsWithChildNeedsStyleRecalc();
}
+ ASSERT(!document().nthIndexCache());
}
void ContainerNode::cloneChildNodes(ContainerNode *clone)
@@ -1158,6 +1160,8 @@ PassRefPtrWillBeRawPtr<Element> ContainerNode::querySelector(const AtomicString&
SelectorQuery* selectorQuery = document().selectorQueryCache().add(selectors, document(), exceptionState);
if (!selectorQuery)
return nullptr;
+
+ Document::UseNthIndexCacheScope nthIndexScope(document());
return selectorQuery->queryFirst(*this);
}
@@ -1172,6 +1176,7 @@ PassRefPtrWillBeRawPtr<StaticElementList> ContainerNode::querySelectorAll(const
if (!selectorQuery)
return nullptr;
+ Document::UseNthIndexCacheScope nthIndexScope(document());
return selectorQuery->queryAll(*this);
}

Powered by Google App Engine
This is Rietveld 408576698