Make dartj2s do type conversions on constructor arguments

tools/dom/scripts/htmldartgenerator.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the system to generate
 dart:html APIs from the IDL database."""
 
 import emitter
 from generator import AnalyzeOperation, ConstantOutputOrder, \
@@ skipping 524 matching lines @@
 
     metadata = self._metadata.GetFormattedMetadata(
         self._library_name, self._interface, self._interface.id, '  ')
 
     if not factory_constructor_name:
       factory_constructor_name = '_create'
       factory_parameters = constructor_info.ParametersAsArgumentList()
     else:
       factory_parameters = ', '.join(constructor_info.factory_parameters)
 
+    def InputType(type_name):
+      conversion = self._InputConversion(
+          type_name, constructor_info.declared_name)
+      if conversion:
+        return conversion.input_type
+      else:
+        return self._NarrowInputType(type_name) if type_name else 'dynamic'
+
     if constructor_info.pure_dart_constructor:
       # TODO(antonm): use common dispatcher generation for this case as well.
       has_optional = any(param_info.is_optional
           for param_info in constructor_info.param_infos)
 
       if not has_optional:
         self._members_emitter.Emit(
             '\n  $(METADATA)'
             'factory $CTOR($PARAMS) => '
             '$FACTORY.$CTOR_FACTORY_NAME($FACTORY_PARAMS);\n',
             CTOR=constructor_info._ConstructorFullName(self._DartType),
-            PARAMS=constructor_info.ParametersAsDeclaration(self._DartType),
+            PARAMS=constructor_info.ParametersAsDeclaration(InputType),
             FACTORY=factory_name,
             METADATA=metadata,
             CTOR_FACTORY_NAME=factory_constructor_name,
             FACTORY_PARAMS=factory_parameters)
       else:
         inits = self._members_emitter.Emit(
             '\n  $(METADATA)'
             'factory $CONSTRUCTOR($PARAMS) {\n'
             '    var e = $FACTORY.$CTOR_FACTORY_NAME($FACTORY_PARAMS);\n'
             '$!INITS'
             '    return e;\n'
             '  }\n',
             CONSTRUCTOR=constructor_info._ConstructorFullName(self._DartType),
             METADATA=metadata,
             FACTORY=factory_name,
             CTOR_FACTORY_NAME=factory_constructor_name,
-            PARAMS=constructor_info.ParametersAsDeclaration(self._DartType),
+            PARAMS=constructor_info.ParametersAsDeclaration(InputType),
             FACTORY_PARAMS=factory_parameters)
 
         for index, param_info in enumerate(constructor_info.param_infos):
           if param_info.is_optional:
             inits.Emit('    if ($E != null) e.$E = $E;\n', E=param_info.name)
     else:
       custom_factory_ctr = self._interface.id in _custom_factories
       constructor_full_name = constructor_info._ConstructorFullName(
           self._DartType)
 
       def GenerateCall(
           stmts_emitter, call_emitter,
           version, signature_index, argument_count):
         name = emitter.Format('_create_$VERSION', VERSION=version)
         arguments = constructor_info.idl_args[signature_index][:argument_count]
+        args = None
         if self._dart_use_blink:
             type_ids = [p.type.id for p in arguments]
             base_name, rs = \
                 self.DeriveNativeEntry("constructorCallback", 'Constructor', argument_count)
             qualified_name = \
                 self.DeriveQualifiedBlinkName(self._interface.id,
                                               base_name)
+            args = constructor_info.ParametersAsArgumentList(argument_count)
         else:
             qualified_name = emitter.Format(
                 '$FACTORY.$NAME',
                 FACTORY=factory_name,
                 NAME=name)
+            (factory_params, converted_arguments) = self._ConvertArgumentTypes(
+                stmts_emitter, arguments, argument_count, constructor_info)
+            args = ', '.join(converted_arguments)
         call_emitter.Emit('$FACTORY_NAME($FACTORY_PARAMS)',
             FACTORY_NAME=qualified_name,
-            FACTORY_PARAMS= \
-                constructor_info.ParametersAsArgumentList(argument_count))
+            FACTORY_PARAMS=args)
         self.EmitStaticFactoryOverload(constructor_info, name, arguments)
 
       def IsOptional(signature_index, argument):
         return self.IsConstructorArgumentOptional(argument)
 
       entry_declaration = emitter.Format(
           '$(METADATA)$FACTORY_KEYWORD $CTOR($PARAMS)',
           FACTORY_KEYWORD=('factory' if not custom_factory_ctr else
                            'static %s' % constructor_full_name),
           CTOR=(('' if not custom_factory_ctr else '_factory')
                 + constructor_full_name),
           METADATA=metadata,
-          PARAMS=constructor_info.ParametersAsDeclaration(self._DartType))
+          PARAMS=constructor_info.ParametersAsDeclaration(InputType))
 
       overload_emitter = self._members_emitter
       overload_declaration = entry_declaration
 
       self._GenerateOverloadDispatcher(
           constructor_info,
           constructor_info.idl_args,
           False,
           overload_declaration,
           GenerateCall,
@@ skipping 150 matching lines @@
     return self._type_registry.TypeInfo(type_name).narrow_dart_type()
 
   def _NarrowInputType(self, type_name):
     return self._NarrowToImplementationType(type_name)
 
   def _DartType(self, type_name):
     return self._type_registry.DartType(type_name)
 
   def _TypeInfo(self, type_name):
     return self._type_registry.TypeInfo(type_name)