Update External Clear Key to support CDM_8

Update External Clear Key to support CDM_8

BUG=450861
TEST=layout tests for ECK pass

Committed: https://crrev.com/3554c93b70d03f44218bc6baabe2e0c57617fa39
Cr-Commit-Position: refs/heads/master@{#321889}

[jrummell, 2015-03-20 21:42:47]

jrummell@chromium.org changed reviewers:
+ ddorwin@chromium.org, sandersd@chromium.org, xhwang@chromium.org

[jrummell, 2015-03-20 21:42:47]

PTAL.

[xhwang, 2015-03-23 20:35:37]

looking good. I just have some nits.

Also, please update CL title to specify "External Clear Key".

https://codereview.chromium.org/1023333002/diff/1/media/cdm/ppapi/external_cl...
File media/cdm/ppapi/external_clear_key/clear_key_cdm.cc (right):

https://codereview.chromium.org/1023333002/diff/1/media/cdm/ppapi/external_cl...
media/cdm/ppapi/external_clear_key/clear_key_cdm.cc:184: NOTIMPLEMENTED();
NOTREACHED()?

https://codereview.chromium.org/1023333002/diff/1/media/cdm/ppapi/external_cl...
media/cdm/ppapi/external_clear_key/clear_key_cdm.cc:298: bool
allow_persistent_state) {
Comment out /* unused_parameter */ ?

https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Dec...

https://codereview.chromium.org/1023333002/diff/1/media/cdm/ppapi/external_cl...
File media/cdm/ppapi/external_clear_key/clear_key_cdm.h (right):

https://codereview.chromium.org/1023333002/diff/1/media/cdm/ppapi/external_cl...
media/cdm/ppapi/external_clear_key/clear_key_cdm.h:35: virtual ~ClearKeyCdm();
Replace "virtual" with "override".

https://codereview.chromium.org/1023333002/diff/1/media/cdm/ppapi/external_cl...
media/cdm/ppapi/external_clear_key/clear_key_cdm.h:39: bool
allow_persistent_state) override;
Here and below, with "override", no need to use "virtual" now.

[jrummell, 2015-03-23 21:47:07]

Updated.

https://codereview.chromium.org/1023333002/diff/1/media/cdm/ppapi/external_cl...
File media/cdm/ppapi/external_clear_key/clear_key_cdm.cc (right):

https://codereview.chromium.org/1023333002/diff/1/media/cdm/ppapi/external_cl...
media/cdm/ppapi/external_clear_key/clear_key_cdm.cc:184: NOTIMPLEMENTED();
On 2015/03/23 20:35:37, xhwang wrote:
> NOTREACHED()?

Done. I just copied what was used in the other conversion routines here, so
updated them all too.

https://codereview.chromium.org/1023333002/diff/1/media/cdm/ppapi/external_cl...
media/cdm/ppapi/external_clear_key/clear_key_cdm.cc:298: bool
allow_persistent_state) {
On 2015/03/23 20:35:37, xhwang wrote:
> Comment out /* unused_parameter */ ?
> 
>
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Dec...

Done.

https://codereview.chromium.org/1023333002/diff/1/media/cdm/ppapi/external_cl...
File media/cdm/ppapi/external_clear_key/clear_key_cdm.h (right):

https://codereview.chromium.org/1023333002/diff/1/media/cdm/ppapi/external_cl...
media/cdm/ppapi/external_clear_key/clear_key_cdm.h:35: virtual ~ClearKeyCdm();
On 2015/03/23 20:35:37, xhwang wrote:
> Replace "virtual" with "override".

Done.

https://codereview.chromium.org/1023333002/diff/1/media/cdm/ppapi/external_cl...
media/cdm/ppapi/external_clear_key/clear_key_cdm.h:39: bool
allow_persistent_state) override;
On 2015/03/23 20:35:37, xhwang wrote:
> Here and below, with "override", no need to use "virtual" now.

Done.

[xhwang, 2015-03-23 21:55:58]

lgtm

[jrummell, 2015-03-23 22:07:42]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2015-03-23 22:08:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1023333002/20001

[commit-bot: I haz the power, 2015-03-23 23:03:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-23 23:04:29]

Patchset 2 (id:??) landed as
https://crrev.com/3554c93b70d03f44218bc6baabe2e0c57617fa39
Cr-Commit-Position: refs/heads/master@{#321889}