Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1023313002: Add font "index" to lmp parser. (Closed)

Created:
5 years, 9 months ago by bungeman-skia
Modified:
5 years, 9 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add font "index" to lmp parser. When ttc index support was added, it was added and tested on Android with the jb parser. This adds it to the lmp parser. Committed: https://skia.googlesource.com/skia/+/b8a1d30a42d13ae83690b2d854a024d9b56e7b71

Patch Set 1 #

Patch Set 2 : Make debug message consistent. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/ports/SkFontConfigParser_android.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
bungeman-skia
5 years, 9 months ago (2015-03-20 21:25:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023313002/20001
5 years, 9 months ago (2015-03-20 21:27:56 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-20 21:27:57 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-20 22:18:09 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 9 months ago (2015-03-21 04:18:12 UTC) #8
djsollen
lgtm
5 years, 9 months ago (2015-03-23 13:23:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023313002/20001
5 years, 9 months ago (2015-03-23 16:03:26 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 16:08:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b8a1d30a42d13ae83690b2d854a024d9b56e7b71

Powered by Google App Engine
This is Rietveld 408576698