Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1023293004: [DevTools] Introduce Unregister/Start/Stop/Inspect buttons to ServiceWorkersView [2/2 blink] (Closed)

Created:
5 years, 9 months ago by horo
Modified:
5 years, 9 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Introduce Unregister/Start/Stop/Inspect buttons to ServiceWorkersView [2/2 blink] 1/2 chromium: https://codereview.chromium.org/1029553002/ 2/2 blink: this cl Screen shot: https://code.google.com/p/chromium/issues/detail?id=466871#c9 BUG=466871 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192410

Patch Set 1 #

Total comments: 6

Patch Set 2 : incorporated pfeldman's comment #

Total comments: 2

Patch Set 3 : this._agent = target.serviceWorkerAgent(); #

Patch Set 4 : update service-workers-view-expected.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -27 lines) Patch
M LayoutTests/http/tests/inspector/service-workers/service-workers-view-expected.txt View 1 2 3 5 chunks +5 lines, -0 lines 0 comments Download
M Source/devtools/front_end/resources/ServiceWorkersView.js View 1 7 chunks +74 lines, -15 lines 0 comments Download
M Source/devtools/front_end/resources/serviceWorkersView.css View 2 chunks +94 lines, -10 lines 0 comments Download
M Source/devtools/front_end/sdk/ServiceWorkerManager.js View 1 2 3 4 chunks +35 lines, -2 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
horo
pfeldman@ Could you please review this?
5 years, 9 months ago (2015-03-23 10:49:32 UTC) #2
pfeldman
https://codereview.chromium.org/1023293004/diff/1/Source/devtools/front_end/resources/ServiceWorkersView.js File Source/devtools/front_end/resources/ServiceWorkersView.js (right): https://codereview.chromium.org/1023293004/diff/1/Source/devtools/front_end/resources/ServiceWorkersView.js#newcode333 Source/devtools/front_end/resources/ServiceWorkersView.js:333: text += " - deleted"; WebInspector.UIString supports message format ...
5 years, 9 months ago (2015-03-23 10:51:09 UTC) #3
horo
Thank you! https://codereview.chromium.org/1023293004/diff/1/Source/devtools/front_end/resources/ServiceWorkersView.js File Source/devtools/front_end/resources/ServiceWorkersView.js (right): https://codereview.chromium.org/1023293004/diff/1/Source/devtools/front_end/resources/ServiceWorkersView.js#newcode333 Source/devtools/front_end/resources/ServiceWorkersView.js:333: text += " - deleted"; On 2015/03/23 ...
5 years, 9 months ago (2015-03-23 11:22:24 UTC) #4
pfeldman
lgtm https://codereview.chromium.org/1023293004/diff/20001/Source/devtools/front_end/sdk/ServiceWorkerManager.js File Source/devtools/front_end/sdk/ServiceWorkerManager.js (right): https://codereview.chromium.org/1023293004/diff/20001/Source/devtools/front_end/sdk/ServiceWorkerManager.js#newcode47 Source/devtools/front_end/sdk/ServiceWorkerManager.js:47: this.enable(); this._agent = target.serviceWorkerAgent(); and use it below.
5 years, 9 months ago (2015-03-23 12:03:14 UTC) #5
horo
Thank you! https://codereview.chromium.org/1023293004/diff/20001/Source/devtools/front_end/sdk/ServiceWorkerManager.js File Source/devtools/front_end/sdk/ServiceWorkerManager.js (right): https://codereview.chromium.org/1023293004/diff/20001/Source/devtools/front_end/sdk/ServiceWorkerManager.js#newcode47 Source/devtools/front_end/sdk/ServiceWorkerManager.js:47: this.enable(); On 2015/03/23 12:03:14, pfeldman wrote: > ...
5 years, 9 months ago (2015-03-23 12:24:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023293004/60001
5 years, 9 months ago (2015-03-24 02:18:31 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 03:50:21 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192410

Powered by Google App Engine
This is Rietveld 408576698