Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 1023273004: Fix a case of writing an empty HexSSID to Shill. (Closed)

Created:
5 years, 9 months ago by pneubeck (no reviews)
Modified:
5 years, 9 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a case of writing an empty HexSSID to Shill. This surfaced when trying to connect to a fake network setup by fake_shill_manager_client.cc. Committed: https://crrev.com/3be384afc1fd8127a07918fb2d8ceaa923d76f85 Cr-Commit-Position: refs/heads/master@{#321783}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M chromeos/network/onc/onc_utils.cc View 1 chunk +12 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
pneubeck (no reviews)
this addresses the issue I mentioned to you last Friday.
5 years, 9 months ago (2015-03-23 11:03:01 UTC) #4
stevenjb
lgtm
5 years, 9 months ago (2015-03-23 15:56:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023273004/40001
5 years, 9 months ago (2015-03-23 15:56:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 9 months ago (2015-03-23 15:59:40 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 16:00:54 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3be384afc1fd8127a07918fb2d8ceaa923d76f85
Cr-Commit-Position: refs/heads/master@{#321783}

Powered by Google App Engine
This is Rietveld 408576698