Issue 1023253003: Revert of Python readability review for dbeam@.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1023253003: Revert of Python readability review for dbeam@. (Closed)

Created:
5 years, 9 months ago by pfeldman

Modified:
5 years, 9 months ago

Reviewers:
Lei Zhang, rothwell, Dan Beam

CC:
chromium-reviews, dbeam+watch-closure_chromium.org, Tyler Breisacher (Chromium)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Python readability review for dbeam@. (patchset #4 id:280001 of https://codereview.chromium.org/476453002/) Reason for revert: http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Full&number=22183 Original issue's description: > Python readability review for dbeam@. > > R=rothwell@google.com > > Committed: https://crrev.com/c5503ce046fdad8c76129c0061f0d6011c2fe92b > Cr-Commit-Position: refs/heads/master@{#321693} TBR=rothwell@google.com,thestig@chromium.org,dbeam@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/1372da21cb6d0463192b07f8414f2ee7597b2035 Cr-Commit-Position: refs/heads/master@{#321701}

Created: 5 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+163 lines, -209 lines)			Patch
M	third_party/closure_compiler/checker.py	View	7 chunks	+120 lines, -173 lines	0 comments	Download
M	third_party/closure_compiler/compile_js.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/closure_compiler/compiler_customization_test.py	View	1 chunk	+9 lines, -8 lines	0 comments	Download
M	third_party/closure_compiler/processor.py	View	6 chunks	+34 lines, -27 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023253003/1

5 years, 9 months ago (2015-03-21 13:13:19 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-21 13:15:23 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1372da21cb6d0463192b07f8414f2ee7597b2035
Cr-Commit-Position: refs/heads/master@{#321701}