Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1023213003: Removing Sky JS Framework tests (Closed)

Created:
5 years, 9 months ago by rafaelw
Modified:
5 years, 9 months ago
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3383 lines) Patch
D sky/tests/framework/binding.sky View 1 chunk +0 lines, -66 lines 0 comments Download
D sky/tests/framework/binding-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D sky/tests/framework/citylist.sky View 1 chunk +0 lines, -10 lines 0 comments Download
D sky/tests/framework/citylist-expected.txt View 1 chunk +0 lines, -243 lines 0 comments Download
D sky/tests/framework/citylist-scrolled.sky View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/tests/framework/citylist-scrolled-expected.txt View 1 chunk +0 lines, -243 lines 0 comments Download
D sky/tests/framework/flights-app.sky View 1 chunk +0 lines, -32 lines 0 comments Download
D sky/tests/framework/flights-app-expected.txt View 1 chunk +0 lines, -169 lines 0 comments Download
D sky/tests/framework/flights-app-pixels.sky View 1 chunk +0 lines, -338 lines 0 comments Download
D sky/tests/framework/flights-app-pixels-expected.sky View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/tests/framework/observe.sky View 1 chunk +0 lines, -1735 lines 0 comments Download
D sky/tests/framework/observe-expected.txt View 1 chunk +0 lines, -87 lines 0 comments Download
D sky/tests/framework/templates.sky View 1 chunk +0 lines, -224 lines 0 comments Download
D sky/tests/framework/templates-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/tests/framework/xmlhttprequest/empty-responseType.sky View 1 chunk +0 lines, -21 lines 0 comments Download
D sky/tests/framework/xmlhttprequest/empty-responseType-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/framework/xmlhttprequest/resources/pass.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/framework/xmlhttprequest/responseType.sky View 1 chunk +0 lines, -19 lines 0 comments Download
D sky/tests/framework/xmlhttprequest/responseType-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/framework/xmlhttprequest/unicode-post.sky View 1 chunk +0 lines, -22 lines 0 comments Download
D sky/tests/framework/xmlhttprequest/unicode-post-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/framework/xmlhttprequest/xhr.sky View 1 chunk +0 lines, -23 lines 0 comments Download
D sky/tests/framework/xmlhttprequest/xhr-does-not-exist.sky View 1 chunk +0 lines, -26 lines 0 comments Download
D sky/tests/framework/xmlhttprequest/xhr-does-not-exist-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/framework/xmlhttprequest/xhr-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/framework/xmlhttprequest/xhr-relative.sky View 1 chunk +0 lines, -20 lines 0 comments Download
D sky/tests/framework/xmlhttprequest/xhr-relative-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
eseidel
lgtm
5 years, 9 months ago (2015-03-20 20:59:47 UTC) #3
rafaelw
5 years, 9 months ago (2015-03-20 21:04:44 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
913a104707db2a66160064ad79924f890ac64a5a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698