Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1023203002: [New Multicolumn] Leave remaining disabled test disabled, and explain why. (Closed)

Created:
5 years, 9 months ago by mstensho (USE GERRIT)
Modified:
5 years, 9 months ago
Reviewers:
rune
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

[New Multicolumn] Leave remaining disabled test disabled, and explain why. I've gone through all interesting multicol tests that needed to be converted to reftests, js-tests (or at least something that isn't dump-render-tree or PNG tests). The remaining tests either provide no additional test coverage, or are invalid (albeit passing in the old implementation), so just keep them disabled. Will be removed once the old multicol implementation is gone (that's crbug.com/408123). BUG=386567 R=rune@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192340

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -26 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +34 lines, -26 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 9 months ago (2015-03-20 14:01:22 UTC) #1
rune
lgtm
5 years, 9 months ago (2015-03-23 07:58:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023203002/1
5 years, 9 months ago (2015-03-23 08:41:55 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 10:02:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192340

Powered by Google App Engine
This is Rietveld 408576698