Issue 10232012: Fourth attempt to add engine to the build

Issue 10232012: Fourth attempt to add engine to the build (Closed)

Created:
8 years, 8 months ago by Brian Wilkerson

Modified:
8 years, 8 months ago

Reviewers:
danrubel

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fourth attempt to add engine to the build. Turns out there was an extra space on the last line of the manifest file, which might have caused the failure. Committed: https://code.google.com/p/dart/source/detail?r=7031

Patch Set 1 #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -5 lines)			Patch
M	editor/tools/features/com.google.dart.tools.deploy.feature/feature.xml	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	editor/tools/features/com.google.dart.tools.tests.feature/feature.xml	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/META-INF/MANIFEST.MF	View	1 chunk	+0 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

danrubel

LGTM with one tweak. http://codereview.chromium.org/10232012/diff/1/editor/tools/plugins/com.google.dart.engine/META-INF/MANIFEST.MF File editor/tools/plugins/com.google.dart.engine/META-INF/MANIFEST.MF (right): http://codereview.chromium.org/10232012/diff/1/editor/tools/plugins/com.google.dart.engine/META-INF/MANIFEST.MF#newcode22 editor/tools/plugins/com.google.dart.engine/META-INF/MANIFEST.MF:22: third_party/json/r2_20080312/json.jar There must be a ...

8 years, 8 months ago (2012-04-26 17:48:03 UTC) #2

Brian Wilkerson

8 years, 8 months ago (2012-04-26 17:51:08 UTC) #3

http://codereview.chromium.org/10232012/diff/1/editor/tools/plugins/com.googl...
File editor/tools/plugins/com.google.dart.engine/META-INF/MANIFEST.MF (right):

http://codereview.chromium.org/10232012/diff/1/editor/tools/plugins/com.googl...
editor/tools/plugins/com.google.dart.engine/META-INF/MANIFEST.MF:22:
third_party/json/r2_20080312/json.jar
> There must be a blank line at the end, but it must be an *empty* line (no
> whitespace). Inspecting the original file reveals a space character on what
> appears to be an empty line. Apparently OSGi is quite picky about this.

Yes. And in my development environment there is a blank line at the end of the
file, even though it doesn't show up that way in the code review window.

Expand Messages | Collapse Messages