Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1023193002: Use same parameters for jpeg decoding quality on all platforms. (Closed)

Created:
5 years, 9 months ago by Olle Liljenzin
Modified:
5 years, 9 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use same parameters for jpeg decoding quality on all platforms. This patch will change android to use same decoding parameters as other platforms, thus changing back to dct=int and dither=fs since the faster settings caused visible artifacts that did not justify the small performance gain. BUG=385515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192409

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adding back WTF_USE_LOW_QUALITY_IMAGE_INTERPOLATION that was removed by mistake. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M Source/config.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 21 (4 generated)
Olle Liljenzin
Created a new review that replaces: https://codereview.chromium.org/339143002/
5 years, 9 months ago (2015-03-20 13:48:58 UTC) #2
aelias_OOO_until_Jul13
lgtm, adding chrishtr@ for OWNERS.
5 years, 9 months ago (2015-03-20 18:33:39 UTC) #4
Ken Russell (switch to Gerrit)
owners LGTM
5 years, 9 months ago (2015-03-20 18:49:28 UTC) #5
Peter Kasting
LGTM
5 years, 9 months ago (2015-03-20 19:13:47 UTC) #6
chrishtr
lgtm
5 years, 9 months ago (2015-03-20 19:16:51 UTC) #7
Noel Gordon
https://codereview.chromium.org/1023193002/diff/1/Source/config.h File Source/config.h (left): https://codereview.chromium.org/1023193002/diff/1/Source/config.h#oldcode89 Source/config.h:89: #define WTF_USE_LOW_QUALITY_IMAGE_INTERPOLATION 1 Seems unrelated to JPEG. Can I ...
5 years, 9 months ago (2015-03-21 05:49:26 UTC) #8
Noel Gordon
lgtm > https://codereview.chromium.org/1023193002/diff/1/Source/config.h > File Source/config.h (left): > > https://codereview.chromium.org/1023193002/diff/1/Source/config.h#oldcode89 > Source/config.h:89: #define WTF_USE_LOW_QUALITY_IMAGE_INTERPOLATION 1 ...
5 years, 9 months ago (2015-03-22 13:11:27 UTC) #9
Noel Gordon
Ran trys, not sure you have trybot access?
5 years, 9 months ago (2015-03-23 05:43:00 UTC) #10
Olle Liljenzin
On 2015/03/23 05:43:00, noel gordon wrote: > Ran trys, not sure you have trybot access? ...
5 years, 9 months ago (2015-03-23 08:18:21 UTC) #11
Olle Liljenzin
https://codereview.chromium.org/1023193002/diff/1/Source/config.h File Source/config.h (left): https://codereview.chromium.org/1023193002/diff/1/Source/config.h#oldcode89 Source/config.h:89: #define WTF_USE_LOW_QUALITY_IMAGE_INTERPOLATION 1 On 2015/03/21 05:49:26, noel gordon wrote: ...
5 years, 9 months ago (2015-03-23 08:43:31 UTC) #12
Noel Gordon
On 2015/03/23 08:18:21, Olle Liljenzin wrote: > In the bug you wrote "While we wait... ...
5 years, 9 months ago (2015-03-23 09:15:22 UTC) #13
Noel Gordon
LGTM > On 2015/03/21 05:49:26, noel gordon wrote: > > Seems unrelated to JPEG. Can ...
5 years, 9 months ago (2015-03-23 09:19:34 UTC) #14
Noel Gordon
Alexis mentioned to me off-line, that our YUV JPEG decode path should be ok, as ...
5 years, 9 months ago (2015-03-23 13:52:47 UTC) #15
Olle Liljenzin
On 2015/03/23 13:52:47, noel gordon wrote: > Alexis mentioned to me off-line, that our YUV ...
5 years, 9 months ago (2015-03-23 15:19:17 UTC) #16
Noel Gordon
Let's land it then.
5 years, 9 months ago (2015-03-23 16:59:18 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023193002/20001
5 years, 9 months ago (2015-03-24 03:46:14 UTC) #20
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 03:50:00 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192409

Powered by Google App Engine
This is Rietveld 408576698