Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: src/heap/gc-idle-time-handler.h

Issue 1023153002: Limit rate of full garbage collections triggered by idle notification. Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/gc-idle-time-handler.cc » ('j') | src/heap/gc-idle-time-handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/gc-idle-time-handler.h
diff --git a/src/heap/gc-idle-time-handler.h b/src/heap/gc-idle-time-handler.h
index 6a39b78aaa2fcc24fd5210236f177bf0f9fffc14..3d82686748ad782f116495f388b413d35ccfbfd7 100644
--- a/src/heap/gc-idle-time-handler.h
+++ b/src/heap/gc-idle-time-handler.h
@@ -138,6 +138,8 @@ class GCIdleTimeHandler {
static const size_t kMinTimeForOverApproximatingWeakClosureInMs;
+ static const double kMinMillisecondsInBetweenMarkCompact;
jochen (gone - plz use gerrit) 2015/03/20 12:41:52 MinTime...InMs would be more consistent with the o
Hannes Payer (out of office) 2015/03/20 14:20:39 Done.
+
class HeapState {
public:
void Print();
@@ -155,6 +157,8 @@ class GCIdleTimeHandler {
size_t used_new_space_size;
size_t new_space_capacity;
size_t new_space_allocation_throughput_in_bytes_per_ms;
+ double last_mark_compact_time;
+ double current_time;
};
GCIdleTimeHandler()
@@ -186,7 +190,9 @@ class GCIdleTimeHandler {
static bool ShouldDoMarkCompact(size_t idle_time_in_ms,
size_t size_of_objects,
- size_t mark_compact_speed_in_bytes_per_ms);
+ size_t mark_compact_speed_in_bytes_per_ms,
+ double last_mark_comact_time,
jochen (gone - plz use gerrit) 2015/03/20 12:41:52 idle_time_in_ms is a size_t value. Can last_mark_c
Hannes Payer (out of office) 2015/03/20 14:20:39 Done.
+ double current_time);
static bool ShouldDoContextDisposalMarkCompact(int context_disposed,
double contexts_disposal_rate);
« no previous file with comments | « no previous file | src/heap/gc-idle-time-handler.cc » ('j') | src/heap/gc-idle-time-handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698