Source/core/layout/LayoutTableSection.cpp - Issue 1023133002: Negative row height when cell has percentage height.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutTableSection.cpp

Issue 1023133002: Negative row height when cell has percentage height. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Layout test expectation updated Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/table/table-rowspan-row-height-less-than-content-height.html ('K') | « LayoutTests/fast/table/table-rowspan-row-height-less-than-content-height-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutTableSection.cpp

diff --git a/Source/core/layout/LayoutTableSection.cpp b/Source/core/layout/LayoutTableSection.cpp

index 63e6a0815f5e165059929d22ba614ee60cbeb0a4..13715dbd10623afcc0edecbfdecc50b7cad9f90b 100644

--- a/Source/core/layout/LayoutTableSection.cpp

+++ b/Source/core/layout/LayoutTableSection.cpp

@@ -322,7 +322,7 @@ void LayoutTableSection::distributeExtraRowSpanHeightToPercentRows(LayoutTableCe

// FIXME: Note that this is wrong if we have a percentage above 100% and may make us grow

// above the available space.

- toAdd = std::min(toAdd, extraRowSpanningHeight);

+ toAdd = std::max(std::min(toAdd, extraRowSpanningHeight), 0);

accumulatedPositionIncrease += toAdd;

extraRowSpanningHeight -= toAdd;

percent -= m_grid[row].logicalHeight.percent();