LayoutTests/fast/table/table-rowspan-row-height-less-than-content-height.html - Issue 1023133002: Negative row height when cell has percentage height.

Unified Diff: LayoutTests/fast/table/table-rowspan-row-height-less-than-content-height.html

Issue 1023133002: Negative row height when cell has percentage height. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added Layout test Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/table/table-rowspan-row-height-less-than-content-height-expected.txt » ('j') | Source/core/layout/LayoutTableSection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/table/table-rowspan-row-height-less-than-content-height.html

diff --git a/LayoutTests/fast/table/table-rowspan-row-height-less-than-content-height.html b/LayoutTests/fast/table/table-rowspan-row-height-less-than-content-height.html

new file mode 100644

index 0000000000000000000000000000000000000000..e74953170153441395bc6a9c26d952d65a0b22b7

--- /dev/null

+++ b/LayoutTests/fast/table/table-rowspan-row-height-less-than-content-height.html

@@ -0,0 +1,24 @@

+<!DOCTYPE html>

+<style>

+ table { width : 100px }

+ #perc-height { height : 1% }

esprehn 2015/06/12 06:21:33 #percent-height, don't abbreviate.

a.suchit 2015/06/12 12:40:20 Done.

+</style>

+<script src="../../resources/check-layout.js"></script>

+<body onload="checkLayout('tr');">

+ <h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issues/detail?id=406043">406043</a>. Text Rendering is not correct on page.</h3>

Julien - ping for review 2015/03/26 15:22:10 The name of the bug as well as this CL could be im

a.suchit 2015/06/12 12:40:20 Done.

+ <table border="1">

+ <tr>

+ <td rowspan="4"> This is rowspan cell. It would spanned for 3 rows in table. This is rowspan cell. It would spanned for 3 rows in table. This is rowspan cell. It would spanned for 3 rows in table. This is rowspan cell. It would spanned for 3 rows in table. It would spanned for 3 rows in table. It would spanned for 3 rows in table. It would spanned for 3 rows in table. It would spanned for 3 rows in table.</td>

+ <td> This is first row second column. </td>

+ </tr>

+ <tr data-offset-y="424">

Julien - ping for review 2015/03/26 15:22:10 Can we use meaningful numbers here? It's difficult

a.suchit 2015/06/12 12:40:20 Done.

+ <td id="perc-height"> This is second row first column. But it should display as second column. </td>

+ </tr>

+ <tr data-offset-y="596">

+ <td id="perc-height"> This is third row first column. But it should display as second column. </td>

+ </tr>

+ <tr data-offset-y="822">

+ <td id="perc-height"> This is fourth row first column. But it should display as second column. </td>

+ </tr>

+ </table>

+</body>