Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: Source/core/layout/LayoutTableSection.cpp

Issue 1023133002: Negative row height when cell has percentage height. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Test expected file updated Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/layout/LayoutTableSection.cpp
diff --git a/Source/core/layout/LayoutTableSection.cpp b/Source/core/layout/LayoutTableSection.cpp
index d429db7252bc7090b4ffeff46ca27de4cfc9b792..5c2af5d936590e546a8b73c6baca0fe842d2b205 100644
--- a/Source/core/layout/LayoutTableSection.cpp
+++ b/Source/core/layout/LayoutTableSection.cpp
@@ -322,6 +322,7 @@ void LayoutTableSection::distributeExtraRowSpanHeightToPercentRows(LayoutTableCe
// FIXME: Note that this is wrong if we have a percentage above 100% and may make us grow
// above the available space.
+ toAdd = std::max(toAdd, 0);
toAdd = std::min(toAdd, extraRowSpanningHeight);
Julien - ping for review 2015/07/14 17:02:41 I think a single line would be better as it would
a.suchit 2015/07/20 06:54:09 Done.
accumulatedPositionIncrease += toAdd;
extraRowSpanningHeight -= toAdd;

Powered by Google App Engine
This is Rietveld 408576698