LayoutTests/fast/table/table-rowspan-row-height-less-than-content-height.html - Issue 1023133002: Negative row height when cell has percentage height.

Unified Diff: LayoutTests/fast/table/table-rowspan-row-height-less-than-content-height.html

Issue 1023133002: Negative row height when cell has percentage height. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Test expected file updated Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/TestExpectations ('K') | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/table/table-rowspan-row-height-less-than-content-height-expected.txt » ('j') | Source/core/layout/LayoutTableSection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/table/table-rowspan-row-height-less-than-content-height.html

diff --git a/LayoutTests/fast/table/table-rowspan-row-height-less-than-content-height.html b/LayoutTests/fast/table/table-rowspan-row-height-less-than-content-height.html

new file mode 100644

index 0000000000000000000000000000000000000000..53fd275934d3ab4674e613046d6f5d9ba5d5dc6d

--- /dev/null

+++ b/LayoutTests/fast/table/table-rowspan-row-height-less-than-content-height.html

@@ -0,0 +1,25 @@

+<!DOCTYPE html>

+<style>

+ table { width : 600px }

+ #percent-height { height : 1% }

+ td { font: 15px/1 Ahem }

+</style>

+<script src="../../resources/check-layout.js"></script>

+<body onload="checkLayout('tr');">

+ <h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issues/detail?id=406043">406043</a>. Negative row height when cell has percentage height.</h3>

+ <table border="1">

Julien - ping for review 2015/07/14 17:02:41 Do we need the table border, the cell padding and

a.suchit 2015/07/20 06:54:09 We do not need it. Removed.

+ <tr data-offset-y="2">

+ <td rowspan="4"> This is rowspan cell. It would spanned for 3 rows in table. This is rowspan cell. It would spanned for 3 rows in table.</td>

Julien - ping for review 2015/07/14 17:02:41 I think this is better English: "It would span 3 r

a.suchit 2015/07/20 06:54:09 done. rowspan cell height should be more so it wo

+ <td width="500px"> This is first row second column. </td>

+ </tr>

+ <tr data-offset-y="80">

+ <td id="percent-height"> This is second row first column. But it should display as second column. </td>

+ </tr>

+ <tr data-offset-y="176">

+ <td id="percent-height"> This is third row first column. But it should display as second column. </td>

+ </tr>

+ <tr data-offset-y="227">

+ <td id="percent-height"> This is fourth row first column. But it should display as second column. </td>

+ </tr>

+ </table>

+</body>