LayoutTests/fast/table/table-rowspan-row-height-less-than-content-height.html - Issue 1023133002: Negative row height when cell has percentage height.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/table/table-rowspan-row-height-less-than-content-height.html

Issue 1023133002: Negative row height when cell has percentage height. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added Layout test Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/table/table-rowspan-row-height-less-than-content-height-expected.txt » ('j') | Source/core/layout/LayoutTableSection.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 table { width : 100px }

	4 #perc-height { height : 1% }
	esprehn 2015/06/12 06:21:33 #percent-height, don't abbreviate. #percent-height, don't abbreviate. a.suchit 2015/06/12 12:40:20 Done. Show quoted text On 2015/06/12 06:21:33, esprehn wrote: > #percent-height, don't abbreviate. Done.
	5 </style>

	6 <script src="../../resources/check-layout.js"></script>

	7 <body onload="checkLayout('tr');">

	8 <h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issu es/detail?id=406043">406043</a>. Text Rendering is not correct on page.</h3>
	Julien - ping for review 2015/03/26 15:22:10 The name of the bug as well as this CL could be im The name of the bug as well as this CL could be improved. It's very very very vague as written. Better naming: Negative row height when cell has percentage height a.suchit 2015/06/12 12:40:20 Done. Show quoted text On 2015/03/26 15:22:10, Julien Chaffraix - PST wrote: > The name of the bug as well as this CL could be improved. It's very very very > vague as written. > > Better naming: Negative row height when cell has percentage height Done.
	9 <table border="1">

	10 <tr>

	11 <td rowspan="4"> This is rowspan cell. It would spanned for 3 rows i n table. This is rowspan cell. It would spanned for 3 rows in table. This is row span cell. It would spanned for 3 rows in table. This is rowspan cell. It would spanned for 3 rows in table. It would spanned for 3 rows in table. It would span ned for 3 rows in table. It would spanned for 3 rows in table. It would spanned for 3 rows in table.</td>

	12 <td> This is first row second column. </td>

	13 </tr>

	14 <tr data-offset-y="424">
	Julien - ping for review 2015/03/26 15:22:10 Can we use meaningful numbers here? It's difficult Can we use meaningful numbers here? It's difficult to know if the test is passing or failing with that kind of numbers. Some ideas: * set font to use an easy to remember font-size and line-height. * break your content to have a fixed number of lines (ie it's easy to see how tall the rows should be). a.suchit 2015/06/12 12:40:20 Done. Show quoted text On 2015/03/26 15:22:10, Julien Chaffraix - PST wrote: > Can we use meaningful numbers here? It's difficult to know if the test is > passing or failing with that kind of numbers. > > Some ideas: > * set font to use an easy to remember font-size and line-height. > * break your content to have a fixed number of lines (ie it's easy to see how > tall the rows should be). Done.
	15 <td id="perc-height"> This is second row first column. But it should display as second column. </td>

	16 </tr>

	17 <tr data-offset-y="596">

	18 <td id="perc-height"> This is third row first column. But it should display as second column. </td>

	19 </tr>

	20 <tr data-offset-y="822">

	21 <td id="perc-height"> This is fourth row first column. But it should display as second column. </td>

	22 </tr>

	23 </table>

	24 </body>

OLD	NEW