LayoutTests/fast/table/table-rowspan-row-height-less-than-content-height.html - Issue 1023133002: Negative row height when cell has percentage height.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/table/table-rowspan-row-height-less-than-content-height.html

Issue 1023133002: Negative row height when cell has percentage height. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Test expected file updated Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/TestExpectations ('K') | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/table/table-rowspan-row-height-less-than-content-height-expected.txt » ('j') | Source/core/layout/LayoutTableSection.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 table { width : 600px }

	4 #percent-height { height : 1% }

	5 td { font: 15px/1 Ahem }

	6 </style>

	7 <script src="../../resources/check-layout.js"></script>

	8 <body onload="checkLayout('tr');">

	9 <h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issu es/detail?id=406043">406043</a>. Negative row height when cell has percentage he ight.</h3>

	10 <table border="1">
	Julien - ping for review 2015/07/14 17:02:41 Do we need the table border, the cell padding and Do we need the table border, the cell padding and cell spacing? (the reason is that it makes the numbers very difficult to read) a.suchit 2015/07/20 06:54:09 We do not need it. Removed. Show quoted text On 2015/07/14 17:02:41, Julien Chaffraix - PST wrote: > Do we need the table border, the cell padding and cell spacing? (the reason is > that it makes the numbers very difficult to read) We do not need it. Removed.
	11 <tr data-offset-y="2">

	12 <td rowspan="4"> This is rowspan cell. It would spanned for 3 rows i n table. This is rowspan cell. It would spanned for 3 rows in table.</td>
	Julien - ping for review 2015/07/14 17:02:41 I think this is better English: "It would span 3 r I think this is better English: "It would span 3 rows in the table" Also why is this repeated twice? a.suchit 2015/07/20 06:54:09 done. rowspan cell height should be more so it wo Show quoted text On 2015/07/14 17:02:41, Julien Chaffraix - PST wrote: > I think this is better English: "It would span 3 rows in the table" > > Also why is this repeated twice? done. rowspan cell height should be more so it would go for distribution and 1% cells height would be generated negative row height. Now changed and given explicit height for rowspan cell.
	13 <td width="500px"> This is first row second column. </td>

	14 </tr>

	15 <tr data-offset-y="80">

	16 <td id="percent-height"> This is second row first column. But it sho uld display as second column. </td>

	17 </tr>

	18 <tr data-offset-y="176">

	19 <td id="percent-height"> This is third row first column. But it shou ld display as second column. </td>

	20 </tr>

	21 <tr data-offset-y="227">

	22 <td id="percent-height"> This is fourth row first column. But it sho uld display as second column. </td>

	23 </tr>

	24 </table>

	25 </body>

OLD	NEW