Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 1023123003: Ensure we don't overflow in BCE (Closed)

Created:
5 years, 9 months ago by Toon Verwaest
Modified:
5 years, 9 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M src/hydrogen-bce.cc View 1 chunk +2 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-bce-underflow.js View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
PTAL
5 years, 9 months ago (2015-03-20 15:58:59 UTC) #2
dcarney
lgtm
5 years, 9 months ago (2015-03-20 16:00:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023123003/1
5 years, 9 months ago (2015-03-20 16:16:50 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0f573464e69087a7d592d7207e1ff7231abfd93c Cr-Commit-Position: refs/heads/master@{#27346}
5 years, 9 months ago (2015-03-20 16:43:16 UTC) #6
Toon Verwaest
5 years, 9 months ago (2015-03-20 16:43:19 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0f573464e69087a7d592d7207e1ff7231abfd93c (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698