Let ImportantFileWriter Use fdatasync

base/files/important_file_writer.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/important_file_writer.h"
 
 #include <stdio.h>
 
 #include <string>
 
@@ skipping 72 matching lines @@
   File tmp_file(tmp_file_path, File::FLAG_OPEN | File::FLAG_WRITE);
   if (!tmp_file.IsValid()) {
     LogFailure(path, FAILED_OPENING, "could not open temporary file");
     return false;
   }
 
   // If this happens in the wild something really bad is going on.
   CHECK_LE(data.length(), static_cast<size_t>(kint32max));
   int bytes_written = tmp_file.Write(0, data.data(),
                                      static_cast<int>(data.length()));
-  bool flush_success = tmp_file.Flush();
+  bool flush_success = tmp_file.FlushData();

[rvargas (doing something else), 2015/03/20 18:56:05]

Incidentally, crbug.com/468046 is about doing _more_ work here instead of less.

[hashimoto, 2015/03/20 19:38:57]

Hmm, ImportantFileWriter's slowness is already a problem (crbug.com/469071).
Is it possible to do something to make it faster? (e.g. always keep 2 files to
avoid creating a temporary file every time, toggling between them when write
happens.)

[hashimoto, 2015/03/20 19:40:30]

Oops, wrong bug number.
crbug.com/418627 is the correct one.

[rvargas (doing something else), 2015/03/20 21:43:00]

Shouldn't we profile it from the field? The fact that it appears in a crash
(caused by a slow shutdown) doesn't really imply that the operation is too slow
(as in, having actual numbers will probably tell us more about what's going on).

On the other hand, while I really see no issue in ignoring some metadata (like
the times) when writing an "important" file, I see the issue in returning too
soon saying all's done only to find out after reboot that there's no file (or an
old one).

Before deciding to do something else to make this faster we need some data.

   tmp_file.Close();
 
   if (bytes_written < static_cast<int>(data.length())) {
     LogFailure(path, FAILED_WRITING, "error writing, bytes_written=" +
                IntToString(bytes_written));
     base::DeleteFile(tmp_file_path, false);
     return false;
   }
 
   if (!flush_success) {
@@ skipping 109 matching lines @@
 
 void ImportantFileWriter::ForwardSuccessfulWrite(bool result) {
   DCHECK(CalledOnValidThread());
   if (result && !on_next_successful_write_.is_null()) {
     on_next_successful_write_.Run();
     on_next_successful_write_.Reset();
   }
 }
 
 }  // namespace base