Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1023093002: Files.app: Replace job related code in EventRouter with new JobEventRoter class. (Closed)

Created:
5 years, 9 months ago by hirono
Modified:
5 years, 9 months ago
Reviewers:
mtomasz, fukino
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Replace job related code in EventRouter with new JobEventRoter class. BUG=469039 TEST=None Committed: https://crrev.com/68954c5c8e987bae59ad40b1daaa052ab287404a Cr-Commit-Position: refs/heads/master@{#321542}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update file_manager_private.js. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -173 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/event_router.h View 5 chunks +3 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/event_router.cc View 7 chunks +26 lines, -143 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/job_event_router.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/file_manager_private.idl View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/closure_compiler/externs/file_manager_private.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/background/js/drive_sync_handler.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
hirono
@fukino - PTAL, thanks!
5 years, 9 months ago (2015-03-20 06:41:21 UTC) #1
hirono
PTAL, thanks!
5 years, 9 months ago (2015-03-20 06:41:33 UTC) #3
fukino
lgtm with a nit. Thank you! https://codereview.chromium.org/1023093002/diff/1/chrome/common/extensions/api/file_manager_private.idl File chrome/common/extensions/api/file_manager_private.idl (right): https://codereview.chromium.org/1023093002/diff/1/chrome/common/extensions/api/file_manager_private.idl#newcode355 chrome/common/extensions/api/file_manager_private.idl:355: double processed; nit: ...
5 years, 9 months ago (2015-03-20 07:04:26 UTC) #4
hirono
Thanks! https://codereview.chromium.org/1023093002/diff/1/chrome/common/extensions/api/file_manager_private.idl File chrome/common/extensions/api/file_manager_private.idl (right): https://codereview.chromium.org/1023093002/diff/1/chrome/common/extensions/api/file_manager_private.idl#newcode355 chrome/common/extensions/api/file_manager_private.idl:355: double processed; On 2015/03/20 07:04:25, fukino wrote: > ...
5 years, 9 months ago (2015-03-20 08:05:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023093002/20001
5 years, 9 months ago (2015-03-20 08:05:21 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/50998)
5 years, 9 months ago (2015-03-20 08:11:38 UTC) #10
hirono
@mtomasz - PTAL file_manager_private.idl. Thanks!
5 years, 9 months ago (2015-03-20 08:13:24 UTC) #12
mtomasz
idl lgtm
5 years, 9 months ago (2015-03-20 09:29:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023093002/20001
5 years, 9 months ago (2015-03-20 09:39:23 UTC) #15
hirono
On 2015/03/20 09:29:54, mtomasz wrote: > idl lgtm Thanks!
5 years, 9 months ago (2015-03-20 09:39:57 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-20 10:13:56 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 10:15:06 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/68954c5c8e987bae59ad40b1daaa052ab287404a
Cr-Commit-Position: refs/heads/master@{#321542}

Powered by Google App Engine
This is Rietveld 408576698