[MacViews] Implement size constraints for app windows.

chrome/browser/ui/views/apps/native_frame_view_mac.mm

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/apps/native_frame_view_mac.h"
+
+#import <Cocoa/Cocoa.h>
+
+#import "ui/gfx/mac/coordinate_conversion.h"
+#include "ui/views/widget/widget.h"
+
+// static
+const char NativeFrameViewMac::kViewClassName[] = "NativeFrameViewMac";
+
+NativeFrameViewMac::NativeFrameViewMac(views::Widget* frame)
+    : views::NativeFrameView(frame) {
+}
+
+NativeFrameViewMac::~NativeFrameViewMac() {
+}
+
+gfx::Rect NativeFrameViewMac::GetWindowBoundsForClientBounds(

[tapted, 2015/03/30 06:33:37]

I'm not sure exactly what this is solving

the right way to do this might be something in
AppWindowFrameView::GetWindowBoundsForClientBounds() .. obviously we can't just
#ifdef in the code below, but there is also a global function
views::GetWindowBoundsForClientBounds(..) which is used on Windows (provided by
ui/views/win/hwnd_util.h) -- mac could provide something like that.

Alternatively, maybe NativeFrameViewMac really belongs in ui/views/widget/cocoa
and NativeWidgetMac should provide it... 

Let's chat!

[jackhou1, 2015/03/31 00:50:42]

AppWindow needs something to provide the right inset between the outer (window)
and inner (content) bounds. NativeFrameViewMac is analogous to
GlassAppWindowFrameViewWin.

[tapted, 2015/03/31 01:06:30]

OK I think we should call it NativeAppWindowFrameViewMac then.

[jackhou1, 2015/03/31 01:59:47]

Done.

+    const gfx::Rect& client_bounds) const {
+  NSWindow* ns_window = GetWidget()->GetNativeWindow();
+  gfx::Rect window_bounds = gfx::ScreenRectFromNSRect([ns_window
+      frameRectForContentRect:gfx::ScreenRectToNSRect(client_bounds)]);
+  // Enforce minimum size (1, 1) in case that |client_bounds| is passed with
+  // empty size.
+  if (window_bounds.IsEmpty())
+    window_bounds.set_size(gfx::Size(1, 1));
+  return window_bounds;
+}