Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1023063004: Hotword: Check for the existence of a speaker model. (Closed)

Created:
5 years, 9 months ago by kcarattini
Modified:
5 years, 9 months ago
CC:
chromium-reviews, rlp+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hotword: Check for the existence of a speaker model. BUG=438525 Committed: https://crrev.com/d5d61bfbe952814e030869af35ef338eb2ee9930 Cr-Commit-Position: refs/heads/master@{#321987}

Patch Set 1 #

Patch Set 2 : Fix Typo #

Total comments: 4

Patch Set 3 : Review Comments #

Patch Set 4 : Correct error handling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -3 lines) Patch
M chrome/browser/resources/hotword/manager.js View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/hotword/training_manager.js View 1 2 3 2 chunks +53 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kcarattini
5 years, 9 months ago (2015-03-20 07:17:18 UTC) #2
Anand Mistry (off Chromium)
LGTM with comment fixes. https://codereview.chromium.org/1023063004/diff/20001/chrome/browser/resources/hotword/training_manager.js File chrome/browser/resources/hotword/training_manager.js (right): https://codereview.chromium.org/1023063004/diff/20001/chrome/browser/resources/hotword/training_manager.js#newcode77 chrome/browser/resources/hotword/training_manager.js:77: * Handles a success event ...
5 years, 9 months ago (2015-03-23 03:10:03 UTC) #3
kcarattini
https://codereview.chromium.org/1023063004/diff/20001/chrome/browser/resources/hotword/training_manager.js File chrome/browser/resources/hotword/training_manager.js (right): https://codereview.chromium.org/1023063004/diff/20001/chrome/browser/resources/hotword/training_manager.js#newcode77 chrome/browser/resources/hotword/training_manager.js:77: * Handles a success event on mounting the file ...
5 years, 9 months ago (2015-03-23 22:59:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023063004/60001
5 years, 9 months ago (2015-03-24 11:37:29 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-24 13:16:51 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 13:18:11 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/d5d61bfbe952814e030869af35ef338eb2ee9930
Cr-Commit-Position: refs/heads/master@{#321987}

Powered by Google App Engine
This is Rietveld 408576698