Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Issue 1023013002: Minor cleanup in ios/web utils (Closed)

Created:
5 years, 9 months ago by stuartmorgan
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor cleanup in ios/web utils Addresses minor comments from upstreaming ios/web utility code in a previous CL (<https://codereview.chromium.org/988383002/>) BUG=None Committed: https://crrev.com/a4016d7a56f557111c9fe34e43b2e481e3955132 Cr-Commit-Position: refs/heads/master@{#321579}

Patch Set 1 #

Total comments: 2

Patch Set 2 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M ios/web/crw_network_activity_indicator_manager.mm View 1 4 chunks +3 lines, -6 lines 0 comments Download
M ios/web/history_state_util.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/web/history_state_util_unittest.mm View 1 chunk +1 line, -2 lines 0 comments Download
M ios/web/navigation/nscoder_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/blocked_popup_info.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
stuartmorgan
5 years, 9 months ago (2015-03-19 23:03:35 UTC) #2
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/1023013002/diff/1/ios/web/crw_network_activity_indicator_manager.mm File ios/web/crw_network_activity_indicator_manager.mm (right): https://codereview.chromium.org/1023013002/diff/1/ios/web/crw_network_activity_indicator_manager.mm#newcode57 ios/web/crw_network_activity_indicator_manager.mm:57: [_groupCounts setObject:@(count) Please run "git cl format"
5 years, 9 months ago (2015-03-20 16:10:24 UTC) #3
stuartmorgan
https://codereview.chromium.org/1023013002/diff/1/ios/web/crw_network_activity_indicator_manager.mm File ios/web/crw_network_activity_indicator_manager.mm (right): https://codereview.chromium.org/1023013002/diff/1/ios/web/crw_network_activity_indicator_manager.mm#newcode57 ios/web/crw_network_activity_indicator_manager.mm:57: [_groupCounts setObject:@(count) On 2015/03/20 16:10:24, eugenebut wrote: > Please ...
5 years, 9 months ago (2015-03-20 16:24:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023013002/20001
5 years, 9 months ago (2015-03-20 16:25:37 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-20 16:50:58 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 16:51:53 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a4016d7a56f557111c9fe34e43b2e481e3955132
Cr-Commit-Position: refs/heads/master@{#321579}

Powered by Google App Engine
This is Rietveld 408576698