This reduces so the enrollment dialog so it just spawns a tab.

This reduces so the enrollment dialog so it just spawns a tab.

Since neither WebView or ExtensionDialog support setting window.location from javascript, we have to load the enrollment URI in a full tab, so this changes the enrollment dialog so that it will show a message informing the user what to do, and then launches the URI in a tab.

It means that we're no longer able to continue connecting in the case where the certificate has been added, but at least it's functional.

BUG=chromium-os:29200
TEST=Ran on device, imported ONC, and tested with http and extension enrollment URIs.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135076

[Greg Spencer (Chromium), 2012-05-01 18:58:50]

Steven, I need OWNERS review, and if you have time to do the rest, that would
save me finding someone else for it.

[stevenjb, 2012-05-02 00:31:23]

http://codereview.chromium.org/10230012/diff/5009/chrome/browser/chromeos/enr...
File chrome/browser/chromeos/enrollment_dialog_view.cc (right):

http://codereview.chromium.org/10230012/diff/5009/chrome/browser/chromeos/enr...
chrome/browser/chromeos/enrollment_dialog_view.cc:55: bool Accept();
move Accept() and Close() below virtual overrides.

http://codereview.chromium.org/10230012/diff/5009/chrome/browser/chromeos/enr...
chrome/browser/chromeos/enrollment_dialog_view.cc:216: // being ignored because
we don't know when the enrollment tab is closed.
This sounds like something we should have an issue filed for?

http://codereview.chromium.org/10230012/diff/5009/chrome/browser/chromeos/enr...
chrome/browser/chromeos/enrollment_dialog_view.cc:220: if (uri.IsStandard() ||
uri.scheme() == "chrome-extension") {
Is there a constant for "chrome-extension"?

[Greg Spencer (Chromium), 2012-05-02 21:08:58]

http://codereview.chromium.org/10230012/diff/5009/chrome/browser/chromeos/enr...
File chrome/browser/chromeos/enrollment_dialog_view.cc (right):

http://codereview.chromium.org/10230012/diff/5009/chrome/browser/chromeos/enr...
chrome/browser/chromeos/enrollment_dialog_view.cc:55: bool Accept();
On 2012/05/02 00:31:23, stevenjb (chromium) wrote:
> move Accept() and Close() below virtual overrides.

Actually they are overrides too.  Fixed their signatures, and removed Close
completely because it wasn't used anymore.

http://codereview.chromium.org/10230012/diff/5009/chrome/browser/chromeos/enr...
chrome/browser/chromeos/enrollment_dialog_view.cc:216: // being ignored because
we don't know when the enrollment tab is closed.
On 2012/05/02 00:31:23, stevenjb (chromium) wrote:
> This sounds like something we should have an issue filed for?

Done. http://crosbug.com/30422

http://codereview.chromium.org/10230012/diff/5009/chrome/browser/chromeos/enr...
chrome/browser/chromeos/enrollment_dialog_view.cc:220: if (uri.IsStandard() ||
uri.scheme() == "chrome-extension") {
On 2012/05/02 00:31:23, stevenjb (chromium) wrote:
> Is there a constant for "chrome-extension"?

Not that I could find: mostly we just use raw strings for scheme comparisons. 
Not sure why...

[stevenjb, 2012-05-02 21:12:43]

LGTM

http://codereview.chromium.org/10230012/diff/5009/chrome/browser/chromeos/enr...
File chrome/browser/chromeos/enrollment_dialog_view.cc (right):

http://codereview.chromium.org/10230012/diff/5009/chrome/browser/chromeos/enr...
chrome/browser/chromeos/enrollment_dialog_view.cc:220: if (uri.IsStandard() ||
uri.scheme() == "chrome-extension") {
On 2012/05/02 21:08:59, Greg Spencer (Chromium) wrote:
> On 2012/05/02 00:31:23, stevenjb (chromium) wrote:
> > Is there a constant for "chrome-extension"?
> 
> Not that I could find: mostly we just use raw strings for scheme comparisons. 
> Not sure why...

Yeah, we should change that, but if that's the current pattern I won't push on
changing it here.

[Mihai Parparita -not on Chrome, 2012-05-02 21:30:14]

http://codereview.chromium.org/10230012/diff/5009/chrome/browser/chromeos/enr...
File chrome/browser/chromeos/enrollment_dialog_view.cc (right):

http://codereview.chromium.org/10230012/diff/5009/chrome/browser/chromeos/enr...
chrome/browser/chromeos/enrollment_dialog_view.cc:220: if (uri.IsStandard() ||
uri.scheme() == "chrome-extension") {
On 2012/05/02 21:12:44, stevenjb (chromium) wrote:
> On 2012/05/02 21:08:59, Greg Spencer (Chromium) wrote:
> > On 2012/05/02 00:31:23, stevenjb (chromium) wrote:
> > > Is there a constant for "chrome-extension"?
> > 
> > Not that I could find: mostly we just use raw strings for scheme
comparisons. 
> > Not sure why...
> 
> Yeah, we should change that, but if that's the current pattern I won't push on
> changing it here.

There is chrome::kExtensionScheme (from chrome/common/url_constants.h)

[Greg Spencer (Chromium), 2012-05-02 21:44:25]

http://codereview.chromium.org/10230012/diff/5009/chrome/browser/chromeos/enr...
File chrome/browser/chromeos/enrollment_dialog_view.cc (right):

http://codereview.chromium.org/10230012/diff/5009/chrome/browser/chromeos/enr...
chrome/browser/chromeos/enrollment_dialog_view.cc:220: if (uri.IsStandard() ||
uri.scheme() == "chrome-extension") {
On 2012/05/02 21:30:14, Mihai Parparita wrote:
> There is chrome::kExtensionScheme (from chrome/common/url_constants.h)

Huh, I guess I just didn't see it in the search results.  Fixed.

[commit-bot: I haz the power, 2012-05-02 23:30:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gspencer@chromium.org/10230012/17009

[commit-bot: I haz the power, 2012-05-03 03:13:56]

Change committed as 135076