leveldb: Env no longer implicitly syncs dir for all newly created files.

third_party/leveldatabase/env_chromium_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file.h"
 #include "base/files/file_enumerator.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/test/test_suite.h"
@@ skipping 41 matching lines @@
 TEST(ErrorEncoding, NoEncodedMessage) {
   Status s = Status::IOError("Some message", "from leveldb itself");
   MethodID method = leveldb_env::kRandomAccessFileRead;
   base::File::Error error = base::File::FILE_ERROR_MAX;
   EXPECT_EQ(leveldb_env::NONE, ParseMethodAndError(s, &method, &error));
   EXPECT_EQ(leveldb_env::kRandomAccessFileRead, method);
   EXPECT_EQ(base::File::FILE_ERROR_MAX, error);
 }
 
 template <typename T>
-class MyEnv : public T {
- public:
-  MyEnv() : directory_syncs_(0) {}
-  int directory_syncs() { return directory_syncs_; }
-
- protected:
-  virtual void DidSyncDir(const std::string& fname) {
-    ++directory_syncs_;
-    leveldb_env::ChromiumEnv::DidSyncDir(fname);
-  }
-
- private:
-  int directory_syncs_;
-};
-
-template <typename T>
 class ChromiumEnvMultiPlatformTests : public ::testing::Test {
  public:
 };
 
 typedef ::testing::Types<ChromiumEnv> ChromiumEnvMultiPlatformTestsTypes;
 TYPED_TEST_CASE(ChromiumEnvMultiPlatformTests,
                 ChromiumEnvMultiPlatformTestsTypes);
 
-TYPED_TEST(ChromiumEnvMultiPlatformTests, DirectorySyncing) {
-  MyEnv<TypeParam> env;
-
-  base::ScopedTempDir dir;
-  ASSERT_TRUE(dir.CreateUniqueTempDir());
-  base::FilePath dir_path = dir.path();
-  std::string some_data = "some data";
-  Slice data = some_data;
-
-  std::string manifest_file_name =
-      dir_path.Append(FILE_PATH_LITERAL("MANIFEST-001")).AsUTF8Unsafe();
-  WritableFile* manifest_file_ptr;
-  Status s = env.NewWritableFile(manifest_file_name, &manifest_file_ptr);
-  EXPECT_TRUE(s.ok());
-  scoped_ptr<WritableFile> manifest_file(manifest_file_ptr);
-  manifest_file->Append(data);
-  EXPECT_EQ(0, env.directory_syncs());
-  manifest_file->Append(data);
-  EXPECT_EQ(0, env.directory_syncs());
-
-  std::string sst_file_name =
-      dir_path.Append(FILE_PATH_LITERAL("000003.sst")).AsUTF8Unsafe();
-  WritableFile* sst_file_ptr;
-  s = env.NewWritableFile(sst_file_name, &sst_file_ptr);
-  EXPECT_TRUE(s.ok());
-  scoped_ptr<WritableFile> sst_file(sst_file_ptr);
-  sst_file->Append(data);
-  EXPECT_EQ(0, env.directory_syncs());
-
-  manifest_file->Append(data);
-  EXPECT_EQ(1, env.directory_syncs());
-  manifest_file->Append(data);
-  EXPECT_EQ(1, env.directory_syncs());
-}
-
 int CountFilesWithExtension(const base::FilePath& dir,
                             const base::FilePath::StringType& extension) {
   int matching_files = 0;
   base::FileEnumerator dir_reader(
       dir, false, base::FileEnumerator::FILES);
   for (base::FilePath fname = dir_reader.Next(); !fname.empty();
        fname = dir_reader.Next()) {
     if (fname.MatchesExtension(extension))
       matching_files++;
   }
@@ skipping 91 matching lines @@
   EXPECT_TRUE(status.ok());
   EXPECT_EQ(1U, result.size());
 
   // And a second time should also return one result
   status = env->GetChildren(dir.AsUTF8Unsafe(), &result);
   EXPECT_TRUE(status.ok());
   EXPECT_EQ(1U, result.size());
 }
 
 int main(int argc, char** argv) { return base::TestSuite(argc, argv).Run(); }