bind to localhost instead of all interfaces, and fix closureWrap

bind to localhost instead of all interfaces, and fix closureWrap

R=sigmund@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/04b0b834717f911d6e28dbdc9d841400ead0b87a

[Jennifer Messerly, 2015-03-19 21:09:31]

jmesserly@google.com changed reviewers:
+ sigmund@google.com

[Jennifer Messerly, 2015-03-19 21:09:31]

binding to localhost is more secure for dev servers

[Siggi Cherem (dart-lang), 2015-03-19 21:15:03]

https://codereview.chromium.org/1022923005/diff/20001/lib/devc.dart
File lib/devc.dart (right):

https://codereview.chromium.org/1022923005/diff/20001/lib/devc.dart#newcode278
lib/devc.dart:278: await shelf.serve(handler, 'localhost', port);
mmm, I used to have this but change it to 0.0.0.0 to make it work behind a
proxy. Maybe we can make this a flag instead? I'm ok making localhost the
default.

[Jennifer Messerly, 2015-03-19 21:18:24]

https://codereview.chromium.org/1022923005/diff/20001/lib/devc.dart
File lib/devc.dart (right):

https://codereview.chromium.org/1022923005/diff/20001/lib/devc.dart#newcode278
lib/devc.dart:278: await shelf.serve(handler, 'localhost', port);
On 2015/03/19 21:15:02, Siggi Cherem (dart-lang) wrote:
> mmm, I used to have this but change it to 0.0.0.0 to make it work behind a
> proxy. Maybe we can make this a flag instead? I'm ok making localhost the
> default.

for flag: can it be host name to connect to? That way you can say which
interface to connect, e.g.
--host=192.168.0.2 or --host=jmesserly.at.my.domain and of course, it would
support --host=0.0.0.0. We could also have that example in the help text

[Siggi Cherem (dart-lang), 2015-03-19 21:20:31]

On 2015/03/19 21:18:24, John Messerly wrote:
> https://codereview.chromium.org/1022923005/diff/20001/lib/devc.dart
> File lib/devc.dart (right):
> 
> https://codereview.chromium.org/1022923005/diff/20001/lib/devc.dart#newcode278
> lib/devc.dart:278: await shelf.serve(handler, 'localhost', port);
> On 2015/03/19 21:15:02, Siggi Cherem (dart-lang) wrote:
> > mmm, I used to have this but change it to 0.0.0.0 to make it work behind a
> > proxy. Maybe we can make this a flag instead? I'm ok making localhost the
> > default.
> 
> for flag: can it be host name to connect to? That way you can say which
> interface to connect, e.g.
> --host=192.168.0.2 or --host=jmesserly.at.my.domain and of course, it would
> support --host=0.0.0.0. We could also have that example in the help text

sounds good

[Jennifer Messerly, 2015-03-19 23:17:17]

PTAL

[Jennifer Messerly, 2015-03-19 23:17:50]

On 2015/03/19 23:17:17, John Messerly wrote:
> PTAL

or not. give me a sec :)

[Jennifer Messerly, 2015-03-19 23:17:56]

Patchset #3 (id:40001) has been deleted

[Jennifer Messerly, 2015-03-19 23:21:54]

okay should be good now

[Siggi Cherem (dart-lang), 2015-03-19 23:34:19]

lgtm, thanks

[Jennifer Messerly, 2015-03-20 16:19:17]

Committed patchset #3 (id:60001) manually as
04b0b834717f911d6e28dbdc9d841400ead0b87a (presubmit successful).