Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1022923002: gpu: Benchmark GL_RED instead of GL_LUMINANCE on OpenGL ES3. (Closed)

Created:
5 years, 9 months ago by Daniele Castagna
Modified:
5 years, 9 months ago
Reviewers:
reveman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Benchmark GL_RED instead of GL_LUMINANCE on OpenGL ES3. This patch tests GL_LUMINANCE only when OpenGL is not ES3 and tests GL_RED when on OpengGL ES3. This change should allow crrev.com/1022603002 to run on Android perf bots. Without this patch crrev.com/1022603002 fails on perf bots because glTextureStorage2D doesn't always accept GL_LUMINANCE8 as internalformat. glTextureStorage2D has been added to OpenGL ES3 and it's available as an extension (GL_{EXT,ARB}_texture_storage) prior to that. If glTextureStorage2D is availabe via the extension it accepts GL_LUMINANCE8_EXT as internal format, otherwise it doesn't. BUG=468748 Committed: https://crrev.com/2208da11bfcabfa5bf0e05fbe614a04715f08b4d Cr-Commit-Position: refs/heads/master@{#321462}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M gpu/perftests/texture_upload_perftest.cc View 3 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Daniele Castagna
5 years, 9 months ago (2015-03-19 19:45:25 UTC) #2
reveman
lgtm
5 years, 9 months ago (2015-03-19 21:42:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022923002/1
5 years, 9 months ago (2015-03-19 22:12:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 23:00:41 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 23:01:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2208da11bfcabfa5bf0e05fbe614a04715f08b4d
Cr-Commit-Position: refs/heads/master@{#321462}

Powered by Google App Engine
This is Rietveld 408576698