Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2149)

Issue 1022843005: Revert of Enabling ico decoding with use of png and bmp decoders (Closed)

Created:
5 years, 9 months ago by tomhudson
Modified:
5 years, 9 months ago
Reviewers:
msarett, scroggo, djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@swizzle
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Enabling ico decoding with use of png and bmp decoders (patchset #10 id:280001 of https://codereview.chromium.org/1011343003/) Reason for revert: Reverting on suspicion of massive bot failures - possible command line too long? Original issue's description: > Enabling ico decoding with use of png and bmp decoders > > BUG=skia:3257 > > Committed: https://skia.googlesource.com/skia/+/15bfd075d38e4422a477e22940d06a137f66cc97 TBR=scroggo@google.com,reed@google.com,djsollen@google.com,msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3257 Committed: https://skia.googlesource.com/skia/+/7aa846c6837f527067e7ab5fdeacdbd502696382

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -536 lines) Patch
M dm/DM.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M dm/DMSrcSink.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M gyp/codec.gyp View 1 chunk +1 line, -3 lines 0 comments Download
M include/codec/SkCodec.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/codec/SkCodec.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/codec/SkCodec_libbmp.h View 7 chunks +6 lines, -24 lines 0 comments Download
M src/codec/SkCodec_libbmp.cpp View 14 chunks +60 lines, -160 lines 0 comments Download
D src/codec/SkCodec_libico.h View 1 chunk +0 lines, -62 lines 0 comments Download
D src/codec/SkCodec_libico.cpp View 1 chunk +0 lines, -254 lines 0 comments Download
M src/codec/SkCodec_libpng.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/dm_flags.py View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tomhudson
Created Revert of Enabling ico decoding with use of png and bmp decoders
5 years, 9 months ago (2015-03-24 20:47:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022843005/1
5 years, 9 months ago (2015-03-24 20:47:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/7aa846c6837f527067e7ab5fdeacdbd502696382
5 years, 9 months ago (2015-03-24 20:47:45 UTC) #3
tomhudson
5 years, 9 months ago (2015-03-24 20:55:15 UTC) #4
Message was sent while issue was closed.
adb shell has a hard limit on how long a command can be passed; instead, try
writing the command to a file, pushing it onto the device, chmoding it, and
using adb to execute that one-line script.

Powered by Google App Engine
This is Rietveld 408576698