chrome/browser/ui/passwords/save_password_refusal_combobox_model.cc - Issue 1022843003: New smart passsword bubble algorithm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/save_password_refusal_combobox_model.cc

Issue 1022843003: New smart passsword bubble algorithm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: handle 'Never' correctly Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/save_password_refusal_combobox_model.h ('k') | chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/save_password_refusal_combobox_model.cc

diff --git a/chrome/browser/ui/passwords/save_password_refusal_combobox_model.cc b/chrome/browser/ui/passwords/save_password_refusal_combobox_model.cc

index 8d397ee2f034a06b9aaf4edcff4ccd8ca22f4d75..f826de73a0815b169e1dc010c3800f726e4660f6 100644

--- a/chrome/browser/ui/passwords/save_password_refusal_combobox_model.cc

+++ b/chrome/browser/ui/passwords/save_password_refusal_combobox_model.cc

@@ -7,12 +7,16 @@

#include "chrome/grit/generated_resources.h"

#include "ui/base/l10n/l10n_util.h"

-SavePasswordRefusalComboboxModel::SavePasswordRefusalComboboxModel() {

+SavePasswordRefusalComboboxModel::SavePasswordRefusalComboboxModel(

+ bool never_is_default)

+ : never_is_default_(never_is_default) {

#if !defined(OS_ANDROID)

items_.push_back(

l10n_util::GetStringUTF16(IDS_PASSWORD_MANAGER_CANCEL_BUTTON));

items_.push_back(

l10n_util::GetStringUTF16(IDS_PASSWORD_MANAGER_BLACKLIST_BUTTON));

+ if (never_is_default)

+ swap(items_[0], items_[1]);

#endif

}