New smart passsword bubble algorithm.

chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller_unittest.mm

Index: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller_unittest.mm b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller_unittest.mm
index 3671cf26d5e11755636c1fb33a0b2297ae27a851..87d318038da9f1d9ebf563e78cb5573c1636563a 100644
--- a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller_unittest.mm
@@ -74,6 +74,16 @@ class ManagePasswordsBubblePendingViewControllerTest
     return controller_.get();
   }
 
+  int index_nope() const {
+    SavePasswordRefusalComboboxModel comboboxModel(false);

[groby-ooo-7-16, 2015/03/23 20:19:41]

Why not have a ComboBoxModel member?

[vasilii, 2015/03/24 10:30:53]

Done.

+    return comboboxModel.index_nope();
+  }
+
+  int index_never() const {
+    SavePasswordRefusalComboboxModel comboboxModel(false);
+    return comboboxModel.index_never();
+  }
+
  private:
   base::scoped_nsobject<ManagePasswordsBubblePendingViewController> controller_;
   base::scoped_nsobject<ManagePasswordsBubblePendingViewTestDelegate> delegate_;
@@ -91,7 +101,7 @@ TEST_F(ManagePasswordsBubblePendingViewControllerTest,
 TEST_F(ManagePasswordsBubblePendingViewControllerTest,
        ShouldNopeAndDismissWhenNopeClicked) {
   BubbleCombobox* nopeButton = [controller() nopeButton];
-  ClickMenuItem(nopeButton, SavePasswordRefusalComboboxModel::INDEX_NOPE);
+  ClickMenuItem(nopeButton, index_nope());
 
   EXPECT_TRUE([delegate() dismissed]);
   EXPECT_FALSE(ui_controller()->saved_password());
@@ -101,8 +111,7 @@ TEST_F(ManagePasswordsBubblePendingViewControllerTest,
 TEST_F(ManagePasswordsBubblePendingViewControllerTest,
        ShouldNeverSaveAndDismissWhenNeverSaveClickedWithoutAnyBestMatches) {
   BubbleCombobox* nopeButton = [controller() nopeButton];
-  ClickMenuItem(nopeButton,
-                SavePasswordRefusalComboboxModel::INDEX_NEVER_FOR_THIS_SITE);
+  ClickMenuItem(nopeButton, index_never());
 
   EXPECT_TRUE([delegate() dismissed]);
   EXPECT_FALSE(ui_controller()->saved_password());
@@ -121,8 +130,7 @@ TEST_F(ManagePasswordsBubblePendingViewControllerTest,
   EXPECT_FALSE(model()->local_credentials().empty());
 
   BubbleCombobox* nopeButton = [controller() nopeButton];
-  ClickMenuItem(nopeButton,
-                SavePasswordRefusalComboboxModel::INDEX_NEVER_FOR_THIS_SITE);
+  ClickMenuItem(nopeButton, index_never());
 
   EXPECT_TRUE([delegate() neverSave]);
   EXPECT_FALSE(ui_controller()->saved_password());