Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 102283003: Update icudt46l.dat and related files. (Closed)

Created:
7 years ago by jungshik at Google
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Update icudt46l.dat and related files. We're about to enable using icudt46l.dat instead of static-linking it on Linux, Android and Chrome OS. While testing that CL, it's found that source/data/in/icudt46l.dat was not updated last time when {linux,mac,android}/icudt*S and windows/icudt.dll were updated. The following two items are also updated: 1) The timezone data (latest version : 2013h) 2) Added trnslit/{tr,el,az}_{Upper,Lower,Title}.txt and translit/css3transform.txt so that we can support CSS3 locale-dependent transform. With the above changes, all the ICU data files (*.S, *dll, *dat) on all platforms are regenerated. The section on the ICU data file generation in README.chromium was made clearer as to where to find / how to generate *S and *dat files if one wishes to customize ICU data differently than Chromium does. BUG=72633, 292214, 234797, 304911 TEST=Once ICU is rolled in, 1) build goes fine 2) Israeli DST transition is up to date (see bug 292214 comment 9 as to how to test). R=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239289

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2341 lines, -1646 lines) Patch
M README.chromium View 1 2 3 3 chunks +45 lines, -12 lines 0 comments Download
A android/icudt46l.dat View 1 2 3 Binary file 0 comments Download
M source/data/in/icudt46l.dat View Binary file 0 comments Download
M source/data/misc/metaZones.txt View 1 2 3 23 chunks +115 lines, -11 lines 0 comments Download
M source/data/misc/timezoneTypes.txt View 1 2 3 6 chunks +10 lines, -4 lines 0 comments Download
M source/data/misc/windowsZones.txt View 1 2 3 1 chunk +488 lines, -122 lines 0 comments Download
M source/data/misc/zoneinfo64.txt View 1 2 3 137 chunks +1474 lines, -1496 lines 0 comments Download
A source/data/translit/az_Lower.txt View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
A source/data/translit/az_Title.txt View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
A source/data/translit/az_Upper.txt View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
A source/data/translit/css3transform.txt View 1 2 3 1 chunk +89 lines, -0 lines 1 comment Download
A source/data/translit/el_Lower.txt View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
A source/data/translit/el_Title.txt View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
A source/data/translit/el_Upper.txt View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
A source/data/translit/tr_Lower.txt View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
A source/data/translit/tr_Title.txt View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
A source/data/translit/tr_Upper.txt View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
M source/data/translit/trnslocal.mk View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M windows/icudt.dll View Binary file 0 comments Download

Messages

Total messages: 4 (0 generated)
jungshik at Google
Mark, can you take a look? This CL is mostly date update. I decided to ...
7 years ago (2013-12-04 09:22:57 UTC) #1
Mark Mentovai
LGTM. In the description, do you want 292214 in the BUG list? You duped 310987 ...
7 years ago (2013-12-04 14:06:22 UTC) #2
jungshik at Google
Committed patchset #4 manually as r239289 (presubmit successful).
7 years ago (2013-12-07 01:19:27 UTC) #3
Andrew Hayden (chromium.org)
6 years, 11 months ago (2014-01-15 12:57:35 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/102283003/diff/30001/source/data/translit/css...
File source/data/translit/css3transform.txt (right):

https://codereview.chromium.org/102283003/diff/30001/source/data/translit/css...
source/data/translit/css3transform.txt:7: // File: root.txt
Where did this file come from? I can't find it in the ICU trunk or in release
52-1. Was it hand-generated? Can we fix up the "root.txt" comment as well? Sorry
for the posthumous question...

Powered by Google App Engine
This is Rietveld 408576698