Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1022823003: Move skp nanobench tile size back to 256x256 to see if it fixes nanobench crashes (Closed)

Created:
5 years, 9 months ago by egdaniel
Modified:
5 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move skp nanobench tile size back to 256x256 to see if it fixes nanobench crashes Going back to old nanobench tile size to see if the increase to tile is what has been causing recent nanobench crashes. The crashes seem very nondeterministic and hard to debug manually. 256x256 is too small of a tile to give accurate gpu results but if this fixes we can try some compromise in the middle BUG=skia: Committed: https://skia.googlesource.com/skia/+/5d09568a0c67bc54dfb38552d0136b06d3ebf018

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M bench/SKPBench.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
egdaniel
5 years, 9 months ago (2015-03-19 17:39:43 UTC) #2
robertphillips
lgtm
5 years, 9 months ago (2015-03-19 17:45:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022823003/1
5 years, 9 months ago (2015-03-19 17:46:15 UTC) #5
brian1
On 2015/03/19 17:39:43, egdaniel wrote: Ok as an experiment but I'd rather disable nb on ...
5 years, 9 months ago (2015-03-19 17:46:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/5d09568a0c67bc54dfb38552d0136b06d3ebf018
5 years, 9 months ago (2015-03-19 18:00:14 UTC) #7
egdaniel
On 2015/03/19 17:46:36, brian1 wrote: > On 2015/03/19 17:39:43, egdaniel wrote: > > Ok as ...
5 years, 9 months ago (2015-03-19 18:00:53 UTC) #8
mtklein
5 years, 9 months ago (2015-03-19 18:01:25 UTC) #9
Message was sent while issue was closed.
On 2015/03/19 17:46:36, brian1 wrote:
> On 2015/03/19 17:39:43, egdaniel wrote:
> 
> Ok as an experiment but I'd rather disable nb on this bot than gather data
that
> doesnt reflect chrome on all bots

We can also just set the tiles to 256x256 for this bot, by setting --benchTileW
/ --benchTileH in tools/nanobench_flags.py.

Powered by Google App Engine
This is Rietveld 408576698