Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1022803002: Clarify what APIs return Maybe and MaybeLocal values (Closed)

Created:
5 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Clarify what APIs return Maybe and MaybeLocal values If the Maybe is nothing or the MaybeLocal is empty, it means that the API call either threw an exception or an exception was already pending. In that case, the embedder needs to handle the exception or otherwise react to the failed API call. BUG=v8:3929 R=svenpanne@chromium.org LOG=y Committed: https://crrev.com/5d8e3bfaffd1c0edac4f03b41767b101dd75c482 Cr-Commit-Position: refs/heads/master@{#27298}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M include/v8.h View 4 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 9 months ago (2015-03-19 10:01:51 UTC) #1
Sven Panne
lgtm
5 years, 9 months ago (2015-03-19 10:20:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022803002/1
5 years, 9 months ago (2015-03-19 10:22:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 12:38:40 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 12:38:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d8e3bfaffd1c0edac4f03b41767b101dd75c482
Cr-Commit-Position: refs/heads/master@{#27298}

Powered by Google App Engine
This is Rietveld 408576698