Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1022773002: Oilpan: tidy up finalization of InspectorEmulationAgent following r192106. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: tidy up finalization of InspectorEmulationAgent following r192106. Move InspectorEmulationAgent's self-reference clearing to discardAgent() instead of doing in its destructor, as that will access an already dead WebViewImpl object. R=tkent BUG=467059 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192150

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M Source/web/InspectorEmulationAgent.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/InspectorEmulationAgent.cpp View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
sof
please take a look. dgozman@: please confirm that moving the clearing this reference out of ...
5 years, 9 months ago (2015-03-19 08:14:54 UTC) #2
tkent
lgtm
5 years, 9 months ago (2015-03-19 08:41:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022773002/1
5 years, 9 months ago (2015-03-19 08:51:56 UTC) #6
haraken
LGTM
5 years, 9 months ago (2015-03-19 08:52:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=192150
5 years, 9 months ago (2015-03-19 10:23:11 UTC) #8
dgozman
5 years, 9 months ago (2015-03-19 10:39:25 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698