mojo/services/geometry/public/interfaces/BUILD.gn - Issue 1022703005: Dart: Rebase generated imports from the SDK to the SDK base directory.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/services/geometry/public/interfaces/BUILD.gn

Issue 1022703005: Dart: Rebase generated imports from the SDK to the SDK base directory. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Added comment Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« mojo/public/tools/bindings/generators/mojom_dart_generator.py ('K') | « mojo/services/files/public/interfaces/BUILD.gn ('k') | mojo/services/gpu/public/interfaces/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import("//build/module_args/mojo.gni")	5 import("//build/module_args/mojo.gni")

6 import("$mojo_sdk_root/mojo/public/tools/bindings/mojom.gni")	6 import("$mojo_sdk_root/mojo/public/tools/bindings/mojom.gni")

7	7

8 mojom("interfaces") {	8 mojom("interfaces") {

9 sources = [	9 sources = [

10 "geometry.mojom",	10 "geometry.mojom",

11 ]	11 ]

	12

	13 import_from = mojo_root
	tonyg 2015/03/26 21:06:13 It'd be nice to have a less brittle way for this t It'd be nice to have a less brittle way for this to apply to the whole directory. I can easily see a new service forgetting to set it. zra 2015/03/26 23:33:20 I could write a wrapper template, like service_moj Show quoted text On 2015/03/26 21:06:13, tonyg wrote: > It'd be nice to have a less brittle way for this to apply to the whole > directory. I can easily see a new service forgetting to set it. I could write a wrapper template, like service_mojom() that just sets import_from and forwards all the other parameters, but someone could still mess up and use mojom() instead of service_mojom(). WDYT?
12 }	14 }

OLD	NEW