Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: gyp/giflib.gyp

Issue 1022673011: Creating a new wrapper for gif decoder (Closed) Base URL: https://skia.googlesource.com/skia.git@ico-real
Patch Set: Added comments and do while loop Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gyp/codec.gyp ('k') | src/codec/SkCodec.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/giflib.gyp
diff --git a/gyp/giflib.gyp b/gyp/giflib.gyp
index 57b3c276546e0890403be73b957304e91fdde2c5..e9d990565b6d8deae257aa9d23dc9243da6fe677 100644
--- a/gyp/giflib.gyp
+++ b/gyp/giflib.gyp
@@ -14,9 +14,6 @@
[ 'skia_android_framework == 0',
{
'type': 'static_library',
- 'defines': [
- 'HAVE_CONFIG_H',
- ],
'include_dirs': [
'../third_party/externals/giflib',
],
@@ -35,11 +32,27 @@
'-w'
],
},
+ 'msvs_settings': {
+ 'VCCLCompilerTool': {
+ 'AdditionalOptions': [
+ '/w',
+ ],
+ },
+ },
'sources': [
'../third_party/externals/giflib/dgif_lib.c',
'../third_party/externals/giflib/gifalloc.c',
'../third_party/externals/giflib/gif_err.c',
],
+ 'conditions' : [
+ [ 'skia_os == "win"', {
+ 'include_dirs': [
+ # Used to include a dummy unistd.h file for windows
+ '../third_party/giflib',
+ ],
+ },
+ ],
+ ],
}, { # skia_android_framework
'type': 'none',
'direct_dependent_settings': {
« no previous file with comments | « gyp/codec.gyp ('k') | src/codec/SkCodec.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698