Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3592)

Unified Diff: dm/DM.cpp

Issue 1022673011: Creating a new wrapper for gif decoder (Closed) Base URL: https://skia.googlesource.com/skia.git@ico-real
Patch Set: Added comments and do while loop Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gyp/codec.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DM.cpp
diff --git a/dm/DM.cpp b/dm/DM.cpp
index 84b49dc170d39e67e7c0fd912d8f8779a40adc42..acd4410974c6bef80ef8fe9bec9459832273eb11 100644
--- a/dm/DM.cpp
+++ b/dm/DM.cpp
@@ -153,10 +153,17 @@ static void push_src(const char* tag, Src* s) {
static bool codec_supported(const char* ext) {
// FIXME: Once other versions of SkCodec are available, we can add them to this
// list (and eventually we can remove this check once they are all supported).
- return strcmp(ext, "png") == 0 || strcmp(ext, "PNG") == 0 ||
- strcmp(ext, "bmp") == 0 || strcmp(ext, "BMP") == 0 ||
- strcmp(ext, "ico") == 0 || strcmp(ext, "ICO") == 0 ||
- strcmp(ext, "wbmp") == 0 || strcmp(ext, "WBMP") == 0;
+ static const char* const exts[] = {
+ "bmp", "gif", "png", "ico", "wbmp",
+ "BMP", "GIF", "PNG", "ICO", "WBMP"
+ };
+
+ for (uint32_t i = 0; i < SK_ARRAY_COUNT(exts); i++) {
+ if (0 == strcmp(exts[i], ext)) {
+ return true;
+ }
+ }
+ return false;
}
static void gather_srcs() {
« no previous file with comments | « no previous file | gyp/codec.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698