Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: gyp/giflib.gyp

Issue 1022673011: Creating a new wrapper for gif decoder (Closed) Base URL: https://skia.googlesource.com/skia.git@ico-real
Patch Set: Last time Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gyp/codec.gyp ('k') | src/codec/SkCodec.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/giflib.gyp
diff --git a/gyp/giflib.gyp b/gyp/giflib.gyp
index 57b3c276546e0890403be73b957304e91fdde2c5..e03e559f8c05c4272fb1cd0213f1f982ce35a6b4 100644
--- a/gyp/giflib.gyp
+++ b/gyp/giflib.gyp
@@ -14,11 +14,10 @@
[ 'skia_android_framework == 0',
{
'type': 'static_library',
- 'defines': [
- 'HAVE_CONFIG_H',
- ],
'include_dirs': [
'../third_party/externals/giflib',
+ # Used to include a dummy unistd.h file for windows
+ '../third_party/giflib',
],
'dependencies': [
],
@@ -35,6 +34,17 @@
'-w'
],
},
+ 'msvs_settings': {
+ 'VCCLCompilerTool': {
+ 'AdditionalOptions': [
+ '/w',
+ ],
+ 'AdditionalOptions!': [
+ # Remove the default warning flag
+ '/W3',
scroggo 2015/03/31 18:39:56 I guess this did not work?
msarett 2015/03/31 20:11:40 Unfortunately not. I did a grep for "W3" and it d
scroggo 2015/03/31 20:39:11 I would say no, until someone complains about it.
+ ],
+ },
+ },
'sources': [
'../third_party/externals/giflib/dgif_lib.c',
'../third_party/externals/giflib/gifalloc.c',
« no previous file with comments | « gyp/codec.gyp ('k') | src/codec/SkCodec.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698