Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1022673003: Implementation of new roles added in ARIA 1.1 draft. (Closed)

Created:
5 years, 9 months ago by shreeramk
Modified:
5 years, 9 months ago
Reviewers:
nektarios, dmazzoni
CC:
aboxhall, blink-reviews, dglazkov+blink, dmazzoni, je_julie(Not used)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Implementation of new roles added in ARIA 1.1 draft. New roles added in this CL - searchbox and switch role. BUG=468667 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192232

Patch Set 1 #

Patch Set 2 : Incorporating comments #

Patch Set 3 : Rebasing change to latest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -10 lines) Patch
M LayoutTests/accessibility/aria-fallback-roles.html View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXLayoutObject.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/accessibility/AXNodeObject.cpp View 1 2 3 chunks +12 lines, -5 lines 0 comments Download
M Source/modules/accessibility/AXObject.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXObject.cpp View 1 2 6 chunks +7 lines, -3 lines 0 comments Download
M Source/modules/accessibility/InspectorAccessibilityAgent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M public/web/WebAXEnums.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
shreeramk
PTAL. Thanks!
5 years, 9 months ago (2015-03-19 14:13:24 UTC) #2
dmazzoni
It looks like accessibility/aria-fallback-roles.html needs to be updated because it includes "switch" in the test ...
5 years, 9 months ago (2015-03-19 14:42:29 UTC) #4
nektarios
I don't think there is any implementation of the new roles in this CL. Only ...
5 years, 9 months ago (2015-03-19 21:23:25 UTC) #5
nektarios
lgtm
5 years, 9 months ago (2015-03-19 21:23:32 UTC) #6
nektarios
lgtm but please wait for Dominic.
5 years, 9 months ago (2015-03-19 21:24:18 UTC) #7
dmazzoni
Actually this change maps the roles too - it adds them to the mapping table ...
5 years, 9 months ago (2015-03-19 21:51:38 UTC) #8
shreeramk
Updated the patchset according to comments. PTAL.
5 years, 9 months ago (2015-03-20 04:43:46 UTC) #9
dmazzoni
lgtm
5 years, 9 months ago (2015-03-20 04:52:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022673003/40001
5 years, 9 months ago (2015-03-20 05:38:50 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 08:48:58 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192232

Powered by Google App Engine
This is Rietveld 408576698