Implementation of new roles added in ARIA 1.1 draft.

Implementation of new roles added in ARIA 1.1 draft.

New roles added in this CL - searchbox and switch role.

BUG=468667
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192232

[shreeramk, 2015-03-19 14:13:24]

shreeram.k@samsung.com changed reviewers:
+ dmazzoni@google.com, nektar@chromium.org

[shreeramk, 2015-03-19 14:13:24]

PTAL. Thanks!

[shreeramk, 2015-03-19 14:14:16]

shreeram.k@samsung.com changed reviewers:
+ dmazzoni@chromium.org
- dmazzoni@google.com

[dmazzoni, 2015-03-19 14:42:29]

It looks like accessibility/aria-fallback-roles.html needs to be updated because
it includes "switch" in the test but expects the result to be "checkbox".

Let's just change the test.

[nektarios, 2015-03-19 21:23:25]

I don't think there is any implementation of the new roles in this CL. Only enum
values were added.
If this is the case, I prefer if the title of this patch is changed to reflect
this, i.e., "Added enum values for ...".

[nektarios, 2015-03-19 21:23:32]

lgtm

[nektarios, 2015-03-19 21:24:18]

lgtm but please wait for Dominic.

[dmazzoni, 2015-03-19 21:51:38]

Actually this change maps the roles too - it adds them to the mapping table
in AXObject.cpp. However, more work is required because "switch" inherits
from "checkbox" and "searchbox" inherits from "textbox" - so every place in
the code where you see CheckboxRole you need to update it to include
SwitchRole too, otherwise.

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[shreeramk, 2015-03-20 04:43:46]

Updated the patchset according to comments. PTAL.

[dmazzoni, 2015-03-20 04:52:01]

lgtm

[shreeramk, 2015-03-20 05:38:29]

The CQ bit was checked by shreeram.k@samsung.com

[shreeramk, 2015-03-20 05:38:30]

The patchset sent to the CQ was uploaded after l-g-t-m from nektar@chromium.org,
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1022673003/#ps40001
(title: "Rebasing change to latest")

[commit-bot: I haz the power, 2015-03-20 05:38:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1022673003/40001

[commit-bot: I haz the power, 2015-03-20 08:48:58]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192232