Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: extensions/test/test_web_contents_modal_dialog_manager.cc

Issue 1022663003: Bind open firewall ports to visible application windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a dummy implementation of WebContentsModalDialogManager::CreateNativeWebModalManager to fix lin… Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/test/test_web_contents_modal_dialog_manager.cc
diff --git a/extensions/shell/browser/shell_web_contents_modal_dialog_manager.cc b/extensions/test/test_web_contents_modal_dialog_manager.cc
similarity index 75%
copy from extensions/shell/browser/shell_web_contents_modal_dialog_manager.cc
copy to extensions/test/test_web_contents_modal_dialog_manager.cc
index 266f37960dfc8ffa4f482861fd42b3cb24f21708..6c889ffa39695d32dd36c8f400b45ab711b2db73 100644
--- a/extensions/shell/browser/shell_web_contents_modal_dialog_manager.cc
+++ b/extensions/test/test_web_contents_modal_dialog_manager.cc
@@ -1,4 +1,4 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
+// Copyright 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -10,9 +10,8 @@ SingleWebContentsDialogManager*
WebContentsModalDialogManager::CreateNativeWebModalManager(
gfx::NativeWindow dialog,
SingleWebContentsDialogManagerDelegate* native_delegate) {
- // TODO(oshima): Investigate if we need to implement this.
NOTREACHED();
- return NULL;
+ return nullptr;
}
} // namespace web_modal
« extensions/browser/api/socket/app_firewall_hole_manager.cc ('K') | « extensions/test/DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698