Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: extensions/browser/api/socket/socket.h

Issue 1022663003: Bind open firewall ports to visible application windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a dummy implementation of WebContentsModalDialogManager::CreateNativeWebModalManager to fix lin… Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/socket/socket.h
diff --git a/extensions/browser/api/socket/socket.h b/extensions/browser/api/socket/socket.h
index 59879157bd6f77eb15556013bacde8f9c93a9194..7f33b832e66595deb7bf4569de9b0becdf15918a 100644
--- a/extensions/browser/api/socket/socket.h
+++ b/extensions/browser/api/socket/socket.h
@@ -19,7 +19,7 @@
#include "net/socket/tcp_client_socket.h"
#if defined(OS_CHROMEOS)
-#include "chromeos/network/firewall_hole.h"
+#include "extensions/browser/api/socket/app_firewall_hole_manager.h"
#endif // OS_CHROMEOS
namespace net {
@@ -60,8 +60,10 @@ class Socket : public ApiResource {
void set_hostname(const std::string& hostname) { hostname_ = hostname; }
#if defined(OS_CHROMEOS)
- void set_firewall_hole(scoped_ptr<chromeos::FirewallHole> firewall_hole) {
- firewall_hole_.reset(firewall_hole.release());
+ void set_firewall_hole(
+ scoped_ptr<AppFirewallHole, content::BrowserThread::DeleteOnUIThread>
+ firewall_hole) {
+ firewall_hole_ = firewall_hole.Pass();
}
#endif // OS_CHROMEOS
@@ -148,7 +150,7 @@ class Socket : public ApiResource {
#if defined(OS_CHROMEOS)
// Represents a hole punched in the system firewall for this socket.
- scoped_ptr<chromeos::FirewallHole, content::BrowserThread::DeleteOnUIThread>
+ scoped_ptr<AppFirewallHole, content::BrowserThread::DeleteOnUIThread>
firewall_hole_;
#endif // OS_CHROMEOS
};

Powered by Google App Engine
This is Rietveld 408576698