Automatically trigger installation of high-quality speech synthesis extension.

chrome/browser/extensions/external_provider_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/external_provider_impl.h"
 
 #include <set>
 #include <vector>
 
 #include "base/command_line.h"
@@ skipping 18 matching lines @@
 #include "chrome/common/pref_names.h"
 #include "content/public/browser/browser_thread.h"
 #include "extensions/browser/external_provider_interface.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/manifest.h"
 #include "ui/base/l10n/l10n_util.h"
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/extensions/device_local_account_external_policy_loader.h"
 #include "chrome/browser/chromeos/extensions/external_pref_cache_loader.h"
+#include "chrome/browser/chromeos/extensions/speech_synthesis_loader.h"
 #include "chrome/browser/chromeos/login/user.h"
 #include "chrome/browser/chromeos/login/user_manager.h"
 #include "chrome/browser/chromeos/policy/app_pack_updater.h"
 #include "chrome/browser/chromeos/policy/device_local_account.h"
 #include "chrome/browser/chromeos/policy/device_local_account_policy_service.h"
 #include "chrome/browser/policy/browser_policy_connector.h"
 #else
 #include "chrome/browser/extensions/default_apps.h"
 #endif
 
@@ skipping 402 matching lines @@
     provider_list->push_back(
         linked_ptr<ExternalProviderInterface>(
           new ExternalProviderImpl(
               service,
               app_pack_updater->CreateExternalLoader(),
               profile,
               Manifest::EXTERNAL_PREF,
               Manifest::INVALID_LOCATION,
               Extension::NO_FLAGS)));
   }
+
+  if (!is_chromeos_demo_session) {

[not at google - send to devlin, 2013/12/09 21:08:09]

Could this go in ExternalComponentLoader? It seems to be what you're going for
here.

I mean this stuff all seems rather arbitrary (e.g. why chromeos_demo_session for
one) but that's some kind of precedent.

[dmazzoni, 2013/12/10 07:55:53]

SpeechSynthesisLoader is Chrome OS only. Merging it into ExternalComponentLoader
would just add a bunch of ifdefs.
I was just following the precent. I think it's unlikely this code would be
triggered in a demo session so I could just remove that check. Up to you.

[not at google - send to devlin, 2013/12/10 20:37:48]

So it's more than just #if defined(OS_CHROMEOS)? If so... ok.
I don't have any informed opinion i.e. I don't even really know what a "chromeos
demo session" is.

+    provider_list->push_back(
+        linked_ptr<ExternalProviderInterface>(
+          new ExternalProviderImpl(
+              service,
+              new chromeos::SpeechSynthesisLoader(profile),
+              profile,
+              Manifest::EXTERNAL_COMPONENT,
+              Manifest::EXTERNAL_COMPONENT,
+              Extension::FROM_WEBSTORE | Extension::WAS_INSTALLED_BY_DEFAULT)));
+  }
 #endif
 
   if (!profile->IsManaged() && !is_chromeos_demo_session) {
     provider_list->push_back(
         linked_ptr<ExternalProviderInterface>(
             new ExternalProviderImpl(
                 service,
                 new ExternalPrefLoader(chrome::DIR_EXTERNAL_EXTENSIONS,
                                        check_admin_permissions_on_mac),
                 profile,
@@ skipping 50 matching lines @@
             service,
             new ExternalComponentLoader(),
             profile,
             Manifest::INVALID_LOCATION,
             Manifest::EXTERNAL_COMPONENT,
             Extension::FROM_WEBSTORE | Extension::WAS_INSTALLED_BY_DEFAULT)));
   }
 }
 
 }  // namespace extensions