Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1022613002: Remove custom elements examples, they are no longer maintained (Closed)

Created:
5 years, 9 months ago by eseidel
Modified:
5 years, 9 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove custom elements examples, they are no longer maintained R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0634eb5ba4b6d381640c243bcfac843a2b2b955a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5497 lines) Patch
D sky/examples/custom-element/example-element.sky View 1 chunk +0 lines, -25 lines 0 comments Download
D sky/examples/custom-element/index.sky View 1 chunk +0 lines, -16 lines 0 comments Download
D sky/examples/data/cities.dart View 1 chunk +0 lines, -5005 lines 0 comments Download
D sky/examples/scrolling/index.sky View 1 chunk +0 lines, -10 lines 0 comments Download
D sky/examples/scrolling/scrolling.sky View 1 chunk +0 lines, -38 lines 0 comments Download
D sky/examples/stocks/index.sky View 1 chunk +0 lines, -8 lines 0 comments Download
D sky/examples/stocks/stock.sky View 1 chunk +0 lines, -72 lines 0 comments Download
D sky/examples/stocks/stock-arrow.sky View 1 chunk +0 lines, -98 lines 0 comments Download
D sky/examples/stocks/stocks.sky View 1 chunk +0 lines, -112 lines 0 comments Download
D sky/examples/widgets/index.sky View 1 chunk +0 lines, -8 lines 0 comments Download
D sky/examples/widgets/widget-root.sky View 1 chunk +0 lines, -98 lines 0 comments Download
M sky/framework/elements/sky-drawer.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/elements/sky-ink-splash.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tools/deploy_sdk.py View 1 chunk +0 lines, -4 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
eseidel
5 years, 9 months ago (2015-03-18 20:35:39 UTC) #1
abarth-chromium
https://codereview.chromium.org/1022613002/diff/1/sky/tools/deploy_sdk.py File sky/tools/deploy_sdk.py (left): https://codereview.chromium.org/1022613002/diff/1/sky/tools/deploy_sdk.py#oldcode178 sky/tools/deploy_sdk.py:178: sdk_path('packages/sky/bin/sky')) Did you mean to remove this?
5 years, 9 months ago (2015-03-18 20:36:49 UTC) #2
abarth-chromium
lgtm
5 years, 9 months ago (2015-03-18 20:37:01 UTC) #3
eseidel
5 years, 9 months ago (2015-03-18 20:38:20 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
0634eb5ba4b6d381640c243bcfac843a2b2b955a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698