Changes session restore callback to always happen when tabs are created

Changes session restore callback to always happen when tabs are created

There is no reason to differentiate between sync/async
case. Additionally we may get rid of loading entirely, in which case
the async case would have to change.

TEST=covered by tests
BUG=468458
Committed: https://crrev.com/ae17b0b0da06b898e7716a56235b43287fd3a23e
Cr-Commit-Position: refs/heads/master@{#321582}

[sky, 2015-03-19 17:39:10]

sky@chromium.org changed reviewers:
+ sque@chromium.org

[Simon Que, 2015-03-19 18:56:49]

https://codereview.chromium.org/1022583003/diff/40001/chrome/browser/sessions...
File chrome/browser/sessions/session_restore_browsertest.cc (right):

https://codereview.chromium.org/1022583003/diff/40001/chrome/browser/sessions...
chrome/browser/sessions/session_restore_browsertest.cc:160: if
(no_memory_pressure)
Can you explain what you're doing here? I'm not familiar with it.

[sky, 2015-03-19 19:15:32]

https://codereview.chromium.org/1022583003/diff/40001/chrome/browser/sessions...
File chrome/browser/sessions/session_restore_browsertest.cc (right):

https://codereview.chromium.org/1022583003/diff/40001/chrome/browser/sessions...
chrome/browser/sessions/session_restore_browsertest.cc:160: if
(no_memory_pressure)
On 2015/03/19 18:56:48, Simon Que wrote:
> Can you explain what you're doing here? I'm not familiar with it.

This is necessitated by the change in behavior. These tests all trigger the
async case, which previously meant the notification was sent after all the tabs
loaded. The WaitForTabsToLoad, as the name implies, waits for all the tabs to
load which simulates what was happening before. The one case that doesn't want
the wait is if no_memory_pressure is true. That's because TabLoader effectively
stops when it sees memory pressure.

[sky, 2015-03-20 00:05:32]

sky@chromium.org changed reviewers:
+ marja@chromium.org

[sky, 2015-03-20 00:05:38]

+marja

[Simon Que, 2015-03-20 00:31:16]

lgtm

[sky, 2015-03-20 14:47:50]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2015-03-20 14:48:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1022583003/40001

[commit-bot: I haz the power, 2015-03-20 14:48:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-20 14:48:10]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[sky, 2015-03-20 14:51:15]

sky@chromium.org changed reviewers:
+ skuhne@chromium.org
- marja@chromium.org

[sky, 2015-03-20 14:51:37]

Simon isn't a committer yet, so marja->skuhne (as skuhne is in my time zone).

[Mr4D (OOO till 08-26), 2015-03-20 16:22:38]

lgtm

https://codereview.chromium.org/1022583003/diff/40001/chrome/browser/sessions...
File chrome/browser/sessions/session_restore.cc (right):

https://codereview.chromium.org/1022583003/diff/40001/chrome/browser/sessions...
chrome/browser/sessions/session_restore.cc:1046: std::vector<WebContents*>*
created_contents) {
I did look over the code several times and I am not sure why you need this list.
It appears to be a bit overkill since you only look for the number of restored
tabs. Wouldn't it be better to return the number of tabs restored instead?

[sky, 2015-03-20 16:35:10]

Thanks.

https://codereview.chromium.org/1022583003/diff/40001/chrome/browser/sessions...
File chrome/browser/sessions/session_restore.cc (right):

https://codereview.chromium.org/1022583003/diff/40001/chrome/browser/sessions...
chrome/browser/sessions/session_restore.cc:1046: std::vector<WebContents*>*
created_contents) {
On 2015/03/20 16:22:38, Mr4D wrote:
> I did look over the code several times and I am not sure why you need this
list.
> It appears to be a bit overkill since you only look for the number of restored
> tabs. Wouldn't it be better to return the number of tabs restored instead?

Ya, sorry, I should have explained. TabLoader is going to be changed to get this
vector. That's why I didn't go with a simple int*.

[sky, 2015-03-20 16:35:14]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2015-03-20 16:36:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1022583003/40001

[commit-bot: I haz the power, 2015-03-20 16:52:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-20 16:53:45]

Patchset 3 (id:??) landed as
https://crrev.com/ae17b0b0da06b898e7716a56235b43287fd3a23e
Cr-Commit-Position: refs/heads/master@{#321582}