Issue 1022573002: Fix crash in VPNListNetworkEntry::UpdateFromNetworkState()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1022573002: Fix crash in VPNListNetworkEntry::UpdateFromNetworkState() (Closed)

Created:
5 years, 9 months ago by bartfab (slow)

Modified:
5 years, 9 months ago

Reviewers:
kaliamoorthi

CC:
chromium-reviews, sadrul, stevenjb+watch_chromium.org, oshima+watch_chromium.org, kalyank

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix crash in VPNListNetworkEntry::UpdateFromNetworkState() This CL fixes a crash in VPNListNetworkEntry::UpdateFromNetworkState() introduced by CL 980943005. BUG=460428 TEST=Manual TBR=kaliamoorthi Committed: https://crrev.com/bc1788da2387df32e96b1bc70087197387ba0a8b Cr-Commit-Position: refs/heads/master@{#321185}

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ash/system/chromeos/network/vpn_list_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022573002/1

5 years, 9 months ago (2015-03-18 18:33:01 UTC) #2

kaliamoorthi

On 2015/03/18 18:33:01, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...

5 years, 9 months ago (2015-03-18 18:53:14 UTC) #3

commit-bot: I haz the power

5 years, 9 months ago (2015-03-18 19:10:23 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/bc1788da2387df32e96b1bc70087197387ba0a8b
Cr-Commit-Position: refs/heads/master@{#321185}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages