Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1022543003: replace SkFixedDiv impl with native 64bit math (Closed)

Created:
5 years, 9 months ago by reed2
Modified:
5 years, 9 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

replace SkFixedDiv impl with native 64bit math BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/7c44ca926bf42b3b2e56131f250c0fd58f87ac71

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1 line) Patch
M bench/MathBench.cpp View 1 chunk +44 lines, -0 lines 0 comments Download
M include/core/SkFixed.h View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022543003/1
5 years, 9 months ago (2015-03-19 01:17:09 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-19 01:17:10 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/2652)
5 years, 9 months ago (2015-03-19 01:22:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022543003/20001
5 years, 9 months ago (2015-03-19 01:25:48 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-19 01:25:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022543003/20001
5 years, 9 months ago (2015-03-19 02:04:35 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/7c44ca926bf42b3b2e56131f250c0fd58f87ac71
5 years, 9 months ago (2015-03-19 02:04:48 UTC) #12
reed2
5 years, 9 months ago (2015-03-19 11:10:23 UTC) #13
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1018523008/ by reed@chromium.org.

The reason for reverting is:
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...

layouttests failures.

Powered by Google App Engine
This is Rietveld 408576698