chrome/test/chromedriver/server/http_handler.cc - Issue 1022543002: [chromedriver] Implement DELETE NetworkConditions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/server/http_handler.cc

Issue 1022543002: [chromedriver] Implement DELETE NetworkConditions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Retrieving network conditions after deleting them raises an exception Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/server/http_handler.cc

diff --git a/chrome/test/chromedriver/server/http_handler.cc b/chrome/test/chromedriver/server/http_handler.cc

index 3ae92995c9cd72ace4b60ca63e487f39f26c2f7e..65f05ee941987a0673e8603c3218480a854ebab2 100644

--- a/chrome/test/chromedriver/server/http_handler.cc

+++ b/chrome/test/chromedriver/server/http_handler.cc

@@ -380,6 +380,11 @@ HttpHandler::HttpHandler(

"session/:sessionId/chromium/network_conditions",

WrapToCommand("SetNetworkConditions",

base::Bind(&ExecuteSetNetworkConditions))),

+ CommandMapping(

+ kDelete,

+ "session/:sessionId/chromium/network_conditions",

+ WrapToCommand("DeleteNetworkConditions",

+ base::Bind(&ExecuteDeleteNetworkConditions))),

CommandMapping(kGet,

"session/:sessionId/application_cache/status",

base::Bind(&ExecuteGetStatus)),