Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1022523002: Clean up around text track display state updates (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
fs
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, blink-reviews-html_chromium.org, dglazkov+blink, vcarbune.chromium
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Clean up around text track display state updates Several minor oddities are changed to be hopefully less odd: * CueTimeline need not check activeSetChanged due to an earlier |if (!activeSetChanged) return|. * Move one-time setup of m_displayTree and m_cueBackgroundBox to where they are created. * ASSERT the preconditions guaranteed in VTTCue::updateDisplay() and getDisplayTree(), guaranteed by TextTrackContainer::updateDisplay. * Never remove and m_cueBackgroundBox from m_displayTree, just leave it there and assert that it is so. * Document where m_cueBackgroundBox is actually populated. * Remove a bunch of spec comments where the code doesn't resemble the shape of the spec and FIXMEs that aren't anywhere close to where they would actually be fixed. A link to http://wkb.ug/79916 remains in VTTCueBox::applyCSSProperties(). BUG=322434 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192113

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -45 lines) Patch
M Source/core/html/track/CueTimeline.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/html/track/vtt/VTTCue.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/track/vtt/VTTCue.cpp View 4 chunks +17 lines, -41 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL. Random things that I found while trying to take the crazy out of updateDisplayTree ...
5 years, 9 months ago (2015-03-18 16:53:55 UTC) #2
fs
lgtm
5 years, 9 months ago (2015-03-18 17:02:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022523002/1
5 years, 9 months ago (2015-03-18 17:02:26 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 18:39:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192113

Powered by Google App Engine
This is Rietveld 408576698