Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1022473003: Small misc cleanups in chrome/browser. (Closed)

Created:
5 years, 9 months ago by Lei Zhang
Modified:
5 years, 9 months ago
Reviewers:
Zachary Kuznia
CC:
chromium-reviews, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Small misc cleanups in chrome/browser. Committed: https://crrev.com/d411ef296fc20aaf47516c8b07a78d02ae79eec1 Cr-Commit-Position: refs/heads/master@{#321266}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -19 lines) Patch
M chrome/browser/plugins/chrome_plugin_service_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/plugins/chrome_plugin_service_filter.cc View 2 chunks +7 lines, -15 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 chunk +1 line, -2 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
Please review the entire CL. https://codereview.chromium.org/1022473003/diff/1/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc File chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc (left): https://codereview.chromium.org/1022473003/diff/1/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc#oldcode614 chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:614: const char* extension_id = ...
5 years, 9 months ago (2015-03-18 23:07:49 UTC) #2
Zachary Kuznia
lgtm https://codereview.chromium.org/1022473003/diff/1/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc File chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc (left): https://codereview.chromium.org/1022473003/diff/1/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc#oldcode614 chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:614: const char* extension_id = whitelist[i].c_str(); On 2015/03/18 23:07:49, ...
5 years, 9 months ago (2015-03-18 23:46:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022473003/1
5 years, 9 months ago (2015-03-19 00:04:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 01:56:20 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 01:56:57 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d411ef296fc20aaf47516c8b07a78d02ae79eec1
Cr-Commit-Position: refs/heads/master@{#321266}

Powered by Google App Engine
This is Rietveld 408576698